-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar]: When a "link" displays the same in HCM when default and disabled #2236
Comments
@jnurthen do you have any suggestions in this area? |
If it is disabled it should probably not be rendered as a link. The fact that it takes keyboard focus and changes the hover style is just as much of an issue as the high contrast colour. I don't see any need to change the high contrast colour unless the other issues are also addressed. |
@Westbrook @jnurthen Spectrum CSS can remove the link markup from the disabled examples, but downstream consumers would also need to update their markup for this. Does that make sense for us to do, @Westbrook? |
Sounds like a good path here, then there'd be no interactive border and no focus acceptance. Ship it! |
Tracking this in Jira via CSS-627 |
Closed via #2265 - should be available starting in |
Description
Both the default and disabled variants of the Avatar leverage a yellow outline when delivered in HCM.
Feels like this would be related to the fact that
<a>
elements can't bedisabled
, so we'd need to delivery synthetic rules to this effect rather than relying on native rules as we might have with a<button>
.Steps to reproduce
Expected behavior
Likely that the disabled Avatar uses the disabled text color, which is green in other contexts.
Screenshots
The text was updated successfully, but these errors were encountered: