Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): disabled color for value text and add disabled stories #2579

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(menu): disabled color for value text and add disabled stories #2579

merged 1 commit into from
Mar 4, 2024

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Mar 4, 2024 •
edited by castastrophe
Loading

Description

Increased Storybook coverage for Menu and a fix for a color issue noticed when additional coverage was added.

  • Updates two existing stories to include a disabled menu item with the Switch input.
  • Updates disabled styles so that the value area text also appears with the disabled content color when the menu item is disabled. Confirmed on newer design spec.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Disabled menu items with disabled Switches appear for two Storybook stories, With Actions and With Values and Actions. [@castastrophe]
  • Value text next to switch also appears in disabled content color in With Values and Actions story. [@castastrophe]

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@jawinn
fix(menu): disabled color for value text and add disabled stories
63b4bd5 
- Updates two existing stories to include a disabled menu item with the
  Switch input.
- Updates disabled styles so that the value area text also appears with
  the disabled content color when the menu item is disabled. Noticed
  when updating the stories and confirmed on newer design spec.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

File metrics

Summary

Total size: 3.94 MB*
Total change (Δ): ⬆ 0.79 KB (0.02%)
Table reports on changes to a package's main file. Other changes can be found in the collapsed "Details" below.

Package Size Δ
menu 41.36 KB ⬆ 0.26 KB
Details

menu

File Head Base Δ
index-base.css 41.36 KB 41.11 KB ⬆ 0.26 KB (0.63%)
index-vars.css 41.36 KB 41.11 KB ⬆ 0.26 KB (0.63%)
index.css 41.36 KB 41.11 KB ⬆ 0.26 KB (0.63%)
mods.json 3.33 KB 3.33 KB -
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

🚀 Deployed on https://pr-2579--spectrum-css.netlify.app

@jawinn jawinn mentioned this pull request Mar 4, 2024
Merged
13 tasks
@jawinn jawinn added the run_vrt For use on PRs looking to kick off VRT label Mar 4, 2024
@castastrophe castastrophe merged commit f0fae60 into main Mar 4, 2024
22 checks passed
@castastrophe castastrophe deleted the jawinn/fix-menu-disabled-with-switch branch March 4, 2024 17:25
jawinn added a commit that referenced this pull request Mar 15, 2024
@jawinn
fix(menu): disabled color for value text and add disabled stories (#2579
b2c94d5 
)

- Updates two existing stories to include a disabled menu item with the
  Switch input.
- Updates disabled styles so that the value area text also appears with
  the disabled content color when the menu item is disabled. Noticed
  when updating the stories and confirmed on newer design spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

Assignees
No one assigned
Labels
run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawinn @castastrophe