Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use storybook v8 #2604

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat: use storybook v8 #2604

merged 2 commits into from
Apr 11, 2024

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Mar 22, 2024

Description

Updates our Storybook instance to the latest major release

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@pfulton pfulton mentioned this pull request Mar 22, 2024
9 tasks
@pfulton pfulton requested a review from castastrophe March 22, 2024 18:30
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Mar 22, 2024
Copy link
Contributor

github-actions bot commented Mar 22, 2024

🚀 Deployed on https://pr-2604--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Mar 22, 2024

File metrics

Summary

Total size: 4.57 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@pfulton
Copy link
Collaborator Author

pfulton commented Mar 22, 2024

@castastrophe Interesting that the PR deployed docs site link above doesn't include the link to Storybook.

@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-to-merge and removed run_vrt For use on PRs looking to kick off VRT ready-to-merge labels Apr 1, 2024
@castastrophe castastrophe marked this pull request as draft April 1, 2024 14:09
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Apr 11, 2024
@castastrophe castastrophe marked this pull request as ready for review April 11, 2024 16:40
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and pulled it down locally with no issues! Baselines are looking good, just rerunning them with updates from main and then we can merge.

@castastrophe castastrophe merged commit 166ab23 into main Apr 11, 2024
12 of 13 checks passed
@castastrophe castastrophe deleted the storybook8 branch April 11, 2024 17:16
castastrophe pushed a commit that referenced this pull request Apr 18, 2024
* feat: use storybook v8
* chore: remove deprecated packages, update imports for new packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants