Add menu icon class #331
Merged
Add menu icon class #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazd
requested changes
Oct 15, 2019
| @@ -99,7 +99,7 @@ governing permissions and limitations under the License. | |||
| } | |||
| } | |||
|
|
|||
| .spectrum-Icon { | |||
| .spectrum-Menu-itemIcon { | |||
| /* Don't get smaller, you're an icon! */ | |||
| flex-shrink: 0; | |||
| align-self: flex-start; | |||
There was a problem hiding this comment.
There's another instance below that needs this change. I would say we should also preserve support for the existing markup so we don't have to make a breaking change.
There was a problem hiding this comment.
Ahh! Good catch. Fixed!
lazd
approved these changes
Oct 16, 2019
|
This looks good. I'd say it's a |
Thanks @lazd ! Do I need to add a new commit with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
spectrum-Menu-itemIconclassname.Description
Adds menu specific icon classname for issue #202 and changes all menu instance with icons.