Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 tree view tokens #209

Merged
merged 4 commits into from
Oct 31, 2024
Merged

S2 tree view tokens #209

merged 4 commits into from
Oct 31, 2024

Conversation

PaliwalSparsh
Copy link
Contributor

@PaliwalSparsh PaliwalSparsh commented Oct 31, 2024

Description

Made the following changes to component layout tokens for both mobile and desktop.

New tokens
tree-view-minimum-height
tree-view-minimum-width
tree-view-disclosure-indicator-height
tree-view-disclosure-indicator-width
tree-view-bottom-to-label
tree-view-drag-handle-to-checkbox
tree-view-edge-to-checkbox
tree-view-edge-to-drag-handle
tree-view-end-edge-to-action-area
tree-view-header-to-item
tree-view-item-to-header
tree-view-item-to-item
tree-view-item-to-item-detached
tree-view-label-to-action-area
tree-view-level-increment
tree-view-minimum-top-to-context-area
tree-view-top-to-action-button
tree-view-top-to-checkbox
tree-view-top-to-disclosure-indicator
tree-view-top-to-drag-handle
tree-view-top-to-label

Made the following changes to component opacity tokens for both light and dark.

New tokens
tree-view-selected-row-background-opacity-emphasized
tree-view-selected-row-background-opacity-emphasized-hover

Made the following changes to component color tokens for both light and dark.

New tokens
tree-view-row-background-hover
tree-view-selected-row-background-default
tree-view-selected-row-background-hover
tree-view-selected-row-background-color-emphasized

Motivation and context

Made token changes required for the S2 tree view component.

Related issue

https://jira.corp.adobe.com/browse/SDS-14095

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @PaliwalSparsh PaliwalSparsh requested a review from a team as a code owner October 31, 2024 03:51
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized-hover
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (2) tree-view-selected-row-background-opacity-emphasized, tree-view-selected-row-background-opacity-emphasized-hover
    

    TEST COMPLETE

    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized-hover
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (10) tree-view-disclosure-indicator-height/desktop, tree-view-disclosure-indicator-height/mobile, tree-view-disclosure-indicator-width/desktop, tree-view-disclosure-indicator-width/mobile, tree-view-minimum-height/desktop, tree-view-minimum-height/mobile, tree-view-minimum-width/desktop, tree-view-minimum-width/mobile, tree-view-selected-row-background-opacity-emphasized, tree-view-selected-row-background-opacity-emphasized-hover
    

    TEST COMPLETE

    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-bottom-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-bottom-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-drag-handle-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-drag-handle-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-edge-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-edge-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-edge-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-edge-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-end-edge-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-end-edge-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-header-to-item
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-item-to-header
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-item-to-header
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-item-to-item
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-item-to-item-detached
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-label-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-label-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-level-increment
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-level-increment
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-top-to-context-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-top-to-context-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-action-button
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-action-button
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-disclosure-indicator
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-disclosure-indicator
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized-hover
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (41) tree-view-disclosure-indicator-height/desktop, tree-view-disclosure-indicator-height/mobile, tree-view-disclosure-indicator-width/desktop, tree-view-disclosure-indicator-width/mobile, tree-view-minimum-height/desktop, tree-view-minimum-height/mobile, tree-view-minimum-width/desktop, tree-view-minimum-width/mobile, tree-view-bottom-to-label/desktop, tree-view-bottom-to-label/mobile, tree-view-drag-handle-to-checkbox/desktop, tree-view-drag-handle-to-checkbox/mobile, tree-view-edge-to-checkbox/desktop, tree-view-edge-to-checkbox/mobile, tree-view-edge-to-drag-handle/desktop, tree-view-edge-to-drag-handle/mobile, tree-view-end-edge-to-action-area/desktop, tree-view-end-edge-to-action-area/mobile, tree-view-header-to-item, tree-view-item-to-header/desktop, tree-view-item-to-header/mobile, tree-view-item-to-item, tree-view-item-to-item-detached, tree-view-label-to-action-area/desktop, tree-view-label-to-action-area/mobile, tree-view-level-increment/desktop, tree-view-level-increment/mobile, tree-view-minimum-top-to-context-area/desktop, tree-view-minimum-top-to-context-area/mobile, tree-view-top-to-action-button/desktop, tree-view-top-to-action-button/mobile, tree-view-top-to-checkbox/desktop, tree-view-top-to-checkbox/mobile, tree-view-top-to-disclosure-indicator/desktop, tree-view-top-to-disclosure-indicator/mobile, tree-view-top-to-drag-handle/desktop, tree-view-top-to-drag-handle/mobile, tree-view-top-to-label/desktop, tree-view-top-to-label/mobile, tree-view-selected-row-background-opacity-emphasized, tree-view-selected-row-background-opacity-emphasized-hover
    

    TEST COMPLETE

    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.tree-view.row-background-hover
    UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.tree-view.selected-row-background-color-emphasized
    UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.tree-view.selected-row-background-default
    UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.tree-view.selected-row-background-hover
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-disclosure-indicator-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-height
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-width
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-bottom-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-bottom-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-drag-handle-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-drag-handle-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-edge-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-edge-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-edge-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-edge-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-end-edge-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-end-edge-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-header-to-item
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-item-to-header
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-item-to-header
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-item-to-item
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component.tree-view-item-to-item-detached
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-label-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-label-to-action-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-level-increment
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-level-increment
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-minimum-top-to-context-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-minimum-top-to-context-area
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-action-button
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-action-button
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-checkbox
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-disclosure-indicator
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-disclosure-indicator
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-drag-handle
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/desktop.tree-view-top-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component/mobile.tree-view-top-to-label
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized
    UPDATED METADATA - SPECTRUM UUID: spectrum2/opacity.component.tree-view-selected-row-background-opacity-emphasized-hover
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (45) tree-view-row-background-hover, tree-view-selected-row-background-color-emphasized, tree-view-selected-row-background-default, tree-view-selected-row-background-hover, tree-view-disclosure-indicator-height/desktop, tree-view-disclosure-indicator-height/mobile, tree-view-disclosure-indicator-width/desktop, tree-view-disclosure-indicator-width/mobile, tree-view-minimum-height/desktop, tree-view-minimum-height/mobile, tree-view-minimum-width/desktop, tree-view-minimum-width/mobile, tree-view-bottom-to-label/desktop, tree-view-bottom-to-label/mobile, tree-view-drag-handle-to-checkbox/desktop, tree-view-drag-handle-to-checkbox/mobile, tree-view-edge-to-checkbox/desktop, tree-view-edge-to-checkbox/mobile, tree-view-edge-to-drag-handle/desktop, tree-view-edge-to-drag-handle/mobile, tree-view-end-edge-to-action-area/desktop, tree-view-end-edge-to-action-area/mobile, tree-view-header-to-item, tree-view-item-to-header/desktop, tree-view-item-to-header/mobile, tree-view-item-to-item, tree-view-item-to-item-detached, tree-view-label-to-action-area/desktop, tree-view-label-to-action-area/mobile, tree-view-level-increment/desktop, tree-view-level-increment/mobile, tree-view-minimum-top-to-context-area/desktop, tree-view-minimum-top-to-context-area/mobile, tree-view-top-to-action-button/desktop, tree-view-top-to-action-button/mobile, tree-view-top-to-checkbox/desktop, tree-view-top-to-checkbox/mobile, tree-view-top-to-disclosure-indicator/desktop, tree-view-top-to-disclosure-indicator/mobile, tree-view-top-to-drag-handle/desktop, tree-view-top-to-drag-handle/mobile, tree-view-top-to-label/desktop, tree-view-top-to-label/mobile, tree-view-selected-row-background-opacity-emphasized, tree-view-selected-row-background-opacity-emphasized-hover
    

    TEST COMPLETE

    @GarthDB GarthDB merged commit 52f81f8 into main Oct 31, 2024
    4 checks passed
    @GarthDB GarthDB deleted the paliwalsparsh/SDS-14095-tree-view branch October 31, 2024 16:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants