Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rgb used instead of rgba for a couple tokens #210

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

mrcjhicks
Copy link
Collaborator

Description

transparent-white-900 & transparent-black-900 values where rgb() but have alphas set; should be rgba().

Related Issue

Motivation and Context

Data consistency.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrcjhicks mrcjhicks requested a review from GarthDB October 27, 2023 17:21
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: b0fa8ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Oct 27, 2023

Run report for 9a7d2f03

Total time: 1m 15s | Comparison time: 1m 8s | Estimated loss: 6.9s (9.1% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(18.13.0) 725ms Skipped
🟩 InstallNodeDeps(18.13.0) 13.3s Passed
🟩 SyncNodeProject(visualizer) 0.1ms Passed
🟩 SyncNodeProject(tokens) 0.2ms Passed
🟩 RunTask(visualizer:typescript) 2.5s Passed
🟩 RunTask(tokens:buildTokens) 16.3s Passed
🟩 RunTask(tokens:buildManifest) 257.2ms Passed
🟩 RunTask(visualizer:build) 2.7s Passed
🟩 RunTask(tokens:build) 14.5ms Passed
🟩 RunTask(tokens:generateDiffResult) 4.9s Passed
🟩 RunTask(tokens:test) 2.3s Passed
🟩 SyncNodeProject(site) 0.1ms Passed
🟩 RunTask(site:copySchema) 639.6ms Passed
🟩 RunTask(site:clean) 113ms Passed
🟩 RunTask(site:build) 32.9s Passed
🟩 RunTask(site:export) 1.1s Passed
Touched files
.changeset/good-peas-mix.md
.changeset/happy-students-vanish.md
.changeset/lemon-dragons-raise.md
.changeset/pre.json
.changeset/slimy-emus-enjoy.md
.changeset/strange-rings-love.md
.changeset/warm-experts-beg.md
.github/workflows/deploy-docs.yml
.github/workflows/release.yml
.moon/toolchain.yml
.moon/workspace.yml
package.json
packages/tokens/CHANGELOG.md
packages/tokens/package.json
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json
packages/tokens/src/color-palette.json
packages/tokens/src/icons.json
packages/tokens/src/layout-component.json
packages/tokens/src/layout.json
packages/tokens/src/semantic-color-palette.json
packages/tokens/src/typography.json
packages/tokens/tasks/diff.js
pnpm-lock.yaml
pnpm-workspace.yaml
tools/transform-tokens-json/README.md
tools/transform-tokens-json/moon.yml
tools/transform-tokens-json/package.json
tools/transform-tokens-json/src/lib/shared.js
tools/transform-tokens-json/src/merge-dark-darkest.js
tools/transform-tokens-json/src/merge-spectrum-express.js
tools/transform-tokens-json/test/index.test.js

@GarthDB GarthDB merged commit c0a10b4 into beta Oct 27, 2023
2 checks passed
@GarthDB GarthDB deleted the issue/fix--rgb-to-rgba-correction branch October 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants