Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextual-help-body-size typo #213

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Nov 7, 2023

Description

Fixing a bug; contextual-help-body-size is referencing heading instead of body typography tokens.

Related Issue

DNA-1326

Motivation and Context

Most likely a typo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 68c8edf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Nov 7, 2023

Run report for 244243bb

Total time: 53.9s | Comparison time: 1m 28s | Estimated savings: 34.7s (39.2% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
🟩 SetupNodeTool(18.13.0) 1.7s Passed
🟩 InstallNodeDeps(18.13.0) 6.4s Passed
🟩 SyncNodeProject(tokens) 0.4ms Passed
🟩 SyncNodeProject(site) 0.4ms Passed
🟩 SyncNodeProject(visualizer) 0.2ms Passed
🟩 RunTask(tokens:buildTokens) 17.2s Passed
🟩 RunTask(tokens:buildManifest) 239.1ms Passed
🟩 RunTask(site:copySchema) 66ms Passed
🟩 RunTask(site:clean) 130.7ms Passed
🟩 RunTask(tokens:build) 21.3ms Passed
🟩 RunTask(tokens:generateDiffResult) 24.7s Passed
🟩 RunTask(tokens:test) 24.7s Passed
🟩 RunTask(site:build) 22.8s Passed
🟩 RunTask(site:export) 1.1s Passed
🟩 RunTask(visualizer:typescript) 2.1s Passed
🟩 RunTask(visualizer:build) 1.9s Passed
Touched files
.changeset/lemon-lizards-walk.md
.github/workflows/deploy-docs.yml
.moon/toolchain.yml
package.json
packages/tokens/src/layout-component.json
pnpm-lock.yaml

@GarthDB GarthDB merged commit 068dca4 into main Nov 7, 2023
2 checks passed
@GarthDB GarthDB deleted the garthdb/DNA-1326-contextual-help branch November 7, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant