Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates from spectrum-tokens-studio-data #251

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .changeset/brown-years-perform.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
"@adobe/spectrum-tokens": minor
---

Updates to spacing tokens for the S2 field label component include:

Token: field-label-top-to-asterisk-[medium, large, extra-large]. Only value for extra-large token required updating in the desktop scale. All other sizes presented accurate values.

Token: field-label-top-margin-[medium, large, extra-large]. All values were updated to reflect 0px for both desktop and mobile scales

## Design Motivation

These changes occurred as a result of updates to the field label component for S2.

## Token Diff

_Token values updated (4):_

- `field-label-top-margin-extra-large`
- `field-label-top-margin-large`
- `field-label-top-margin-medium`
- `field-label-top-to-asterisk-extra-large`

## Schema Diff

Adds missing schema information for `corner-radius-1000`. Also added `schemas/token-types/multiplier.json` to the `scale-set` schema.
6 changes: 6 additions & 0 deletions packages/tokens/schemas/token-types/scale-set.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
},
{
"$ref": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/alias.json"
},
{
"$ref": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/multiplier.json"
}
]
},
Expand All @@ -39,6 +42,9 @@
},
{
"$ref": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/alias.json"
},
{
"$ref": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/multiplier.json"
}
]
}
Expand Down
16 changes: 8 additions & 8 deletions packages/tokens/src/layout-component.json
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@
"sets": {
"desktop": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "19px",
"value": "18px",
"uuid": "e53ea4a5-bde5-4695-9ab8-50c2ce704019"
},
"mobile": {
Expand Down Expand Up @@ -603,12 +603,12 @@
"sets": {
"desktop": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "4px",
"value": "0px",
"uuid": "b5243f56-7985-4686-b41f-9b9b9a18b047"
},
"mobile": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "5px",
"value": "0px",
"uuid": "9d00a023-3a33-4b98-819e-3229e03d103b"
}
}
Expand All @@ -619,12 +619,12 @@
"sets": {
"desktop": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "5px",
"value": "0px",
"uuid": "f7dd90d8-91e6-4090-a5a9-6b30087860a4"
},
"mobile": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "6px",
"value": "0px",
"uuid": "f83b208f-dfdb-49a8-aedd-08fe8c7a86a9"
}
}
Expand All @@ -635,12 +635,12 @@
"sets": {
"desktop": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "5px",
"value": "0px",
"uuid": "5c14d528-fe17-4b0b-a123-edbdb93fd173"
},
"mobile": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/dimension.json",
"value": "6px",
"value": "0px",
"uuid": "c4c5e251-d514-42cf-b9e3-56694910e95b"
}
}
Expand Down Expand Up @@ -7061,4 +7061,4 @@
}
}
}
}
}
2 changes: 2 additions & 0 deletions packages/tokens/src/layout.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,12 @@
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/scale-set.json",
"sets": {
"desktop": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/multiplier.json",
"value": "0.5",
"uuid": "e4ad85b2-97bf-48cf-a5a9-3ff3d1fada5b"
},
"mobile": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/multiplier.json",
"value": "0.5",
"uuid": "9cd69903-8417-4d6a-92cf-7ec759d5f60f"
}
Expand Down
Loading