Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove duplicate token set definitions (S2) #257

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

mrcjhicks
Copy link
Collaborator

Description

Consolidates token sets that do not differ in value.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrcjhicks mrcjhicks requested a review from GarthDB February 1, 2024 20:25
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 3303ad8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Feb 1, 2024

Run report for 3303ad80

Total time: 51.9s | Comparison time: 53.1s | Estimated savings: 1.1s (2.2% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(18.13.0) 1.4s Skipped
🟩 InstallNodeDeps(18.13.0) 7.7s Passed
🟩 SyncNodeProject(visualizer) 0.2ms Passed
🟩 SyncNodeProject(tokens) 0.3ms Passed
🟩 SyncNodeProject(site) 0.2ms Passed
🟩 RunTask(visualizer:typescript) 2.3s Passed
🟩 RunTask(tokens:buildTokens) 14.5s Passed
🟩 RunTask(tokens:buildManifest) 267.6ms Passed
🟩 RunTask(site:copySchema) 85.1ms Passed
🟩 RunTask(visualizer:build) 3s Passed
🟩 RunTask(tokens:build) 42.4ms Passed
🟩 RunTask(tokens:generateDiffResult) 3.1s Passed
🟩 RunTask(tokens:test) 3.8s Passed
🟩 RunTask(site:build) 23.6s Passed
🟩 RunTask(site:clean) 104ms Passed
🟩 RunTask(site:export) 845.1ms Passed
Touched files
.changeset/brown-years-perform.md
.changeset/clever-onions-compete.md
.changeset/dirty-pets-attend.md
.changeset/empty-steaks-dress.md
.changeset/forty-lizards-thank.md
.changeset/fuzzy-cherries-buy.md
.changeset/gentle-months-carry.md
.changeset/good-peas-mix.md
.changeset/happy-students-vanish.md
.changeset/lemon-dragons-raise.md
.changeset/neat-balloons-rhyme.md
.changeset/pre.json
.changeset/six-phones-rescue.md
.changeset/slimy-emus-enjoy.md
.changeset/smooth-turtles-retire.md
.changeset/soft-moles-walk.md
.changeset/strange-rings-love.md
.changeset/tame-bobcats-beg.md
.changeset/unlucky-buckets-shop.md
.changeset/warm-experts-beg.md
.changeset/wise-turtles-confess.md
.github/workflows/deploy-docs.yml
.github/workflows/release.yml
.husky/commit-msg
.moon/toolchain.yml
.moon/workspace.yml
commitlint.config.cjs
docs/site/public/schemas/components/action-bar.json
docs/site/public/schemas/components/action-button.json
docs/site/public/schemas/components/action-group.json
docs/site/public/schemas/components/alert-banner.json
docs/site/public/schemas/components/alert-dialog.json
docs/site/public/schemas/components/avatar.json
docs/site/public/schemas/components/badge.json
docs/site/public/schemas/components/body.json
docs/site/public/schemas/components/bottom-navigation-android.json
docs/site/public/schemas/components/breadcrumbs.json
docs/site/public/schemas/components/button-group.json
docs/site/public/schemas/components/button.json
docs/site/public/schemas/components/checkbox-group.json
docs/site/public/schemas/components/checkbox.json
docs/site/public/schemas/components/close-button.json
docs/site/public/schemas/components/code.json
docs/site/public/schemas/components/color-area.json
docs/site/public/schemas/components/color-loupe.json
docs/site/public/schemas/components/color-slider.json
docs/site/public/schemas/components/color-wheel.json
docs/site/public/schemas/components/combo-box.json
docs/site/public/schemas/components/contextual-help.json
docs/site/public/schemas/components/detail.json
docs/site/public/schemas/components/divider.json
docs/site/public/schemas/components/field-label.json
docs/site/public/schemas/components/heading.json
docs/site/public/schemas/components/help-text.json
docs/site/public/schemas/components/in-line-alert.json
docs/site/public/schemas/components/link.json
docs/site/public/schemas/components/menu.json
docs/site/public/schemas/components/meter.json
docs/site/public/schemas/components/picker.json
docs/site/public/schemas/components/popover.json
docs/site/public/schemas/components/progress-bar.json
docs/site/public/schemas/components/progress-circle.json
docs/site/public/schemas/components/radio-group.json
docs/site/public/schemas/components/rating.json
docs/site/public/schemas/components/scroll-zoom-bar.json
docs/site/public/schemas/components/side-navigation.json
docs/site/public/schemas/components/slider.json
docs/site/public/schemas/components/status-light.json
docs/site/public/schemas/components/swatch-group.json
docs/site/public/schemas/components/swatch.json
docs/site/public/schemas/components/switch.json
docs/site/public/schemas/components/tab-bar-ios.json
docs/site/public/schemas/components/tabs.json
docs/site/public/schemas/components/tag.json
docs/site/public/schemas/components/text-area.json
docs/site/public/schemas/components/text-field.json
docs/site/public/schemas/components/toast.json
docs/site/public/schemas/components/tooltip.json
docs/site/public/schemas/components/tray.json
docs/site/public/schemas/components/tree-view.json
docs/site/public/schemas/token-types/alias.json
docs/site/public/schemas/token-types/color-set.json
docs/site/public/schemas/token-types/color.json
docs/site/public/schemas/token-types/dimension.json
docs/site/public/schemas/token-types/font-family.json
docs/site/public/schemas/token-types/font-size.json
docs/site/public/schemas/token-types/font-style.json
docs/site/public/schemas/token-types/font-weight.json
docs/site/public/schemas/token-types/multiplier.json
docs/site/public/schemas/token-types/opacity.json
docs/site/public/schemas/token-types/scale-set.json
docs/site/public/schemas/token-types/set.json
docs/site/public/schemas/token-types/text-transform.json
docs/site/public/schemas/token-types/token.json
package-lock.json
package.json
packages/tokens/CHANGELOG.md
packages/tokens/moon.yml
packages/tokens/package.json
packages/tokens/schemas/components/action-bar.json
packages/tokens/schemas/components/action-button.json
packages/tokens/schemas/components/action-group.json
packages/tokens/schemas/components/alert-banner.json
packages/tokens/schemas/components/alert-dialog.json
packages/tokens/schemas/components/avatar.json
packages/tokens/schemas/components/badge.json
packages/tokens/schemas/components/body.json
packages/tokens/schemas/components/bottom-navigation-android.json
packages/tokens/schemas/components/breadcrumbs.json
packages/tokens/schemas/components/button-group.json
packages/tokens/schemas/components/button.json
packages/tokens/schemas/components/checkbox-group.json
packages/tokens/schemas/components/checkbox.json
packages/tokens/schemas/components/close-button.json
packages/tokens/schemas/components/code.json
packages/tokens/schemas/components/color-area.json
packages/tokens/schemas/components/color-loupe.json
packages/tokens/schemas/components/color-slider.json
packages/tokens/schemas/components/color-wheel.json
packages/tokens/schemas/components/combo-box.json
packages/tokens/schemas/components/contextual-help.json
packages/tokens/schemas/components/detail.json
packages/tokens/schemas/components/divider.json
packages/tokens/schemas/components/field-label.json
packages/tokens/schemas/components/heading.json
packages/tokens/schemas/components/help-text.json
packages/tokens/schemas/components/in-line-alert.json
packages/tokens/schemas/components/link.json
packages/tokens/schemas/components/menu.json
packages/tokens/schemas/components/meter.json
packages/tokens/schemas/components/picker.json
packages/tokens/schemas/components/popover.json
packages/tokens/schemas/components/progress-bar.json
packages/tokens/schemas/components/progress-circle.json
packages/tokens/schemas/components/radio-group.json
packages/tokens/schemas/components/rating.json
packages/tokens/schemas/components/scroll-zoom-bar.json
packages/tokens/schemas/components/side-navigation.json
packages/tokens/schemas/components/slider.json
packages/tokens/schemas/components/status-light.json
packages/tokens/schemas/components/swatch-group.json
packages/tokens/schemas/components/swatch.json
packages/tokens/schemas/components/switch.json
packages/tokens/schemas/components/tab-bar-ios.json
packages/tokens/schemas/components/tabs.json
packages/tokens/schemas/components/tag.json
packages/tokens/schemas/components/text-area.json
packages/tokens/schemas/components/text-field.json
packages/tokens/schemas/components/toast.json
packages/tokens/schemas/components/tooltip.json
packages/tokens/schemas/components/tray.json
packages/tokens/schemas/components/tree-view.json
packages/tokens/schemas/token-types/alias.json
packages/tokens/schemas/token-types/color-set.json
packages/tokens/schemas/token-types/color.json
packages/tokens/schemas/token-types/dimension.json
packages/tokens/schemas/token-types/font-family.json
packages/tokens/schemas/token-types/font-size.json
packages/tokens/schemas/token-types/font-style.json
packages/tokens/schemas/token-types/font-weight.json
packages/tokens/schemas/token-types/multiplier.json
packages/tokens/schemas/token-types/opacity.json
packages/tokens/schemas/token-types/scale-set.json
packages/tokens/schemas/token-types/set.json
packages/tokens/schemas/token-types/text-transform.json
packages/tokens/schemas/token-types/token.json
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json
packages/tokens/src/color-palette.json
packages/tokens/src/icons.json
packages/tokens/src/layout-component.json
packages/tokens/src/layout.json
packages/tokens/src/semantic-color-palette.json
packages/tokens/src/typography.json
packages/tokens/tasks/diff.js
packages/tokens/test/checkId.test.js
packages/tokens/test/componentSchemaValidator.test.js
packages/tokens/test/schemaValidators/alias.test.js
packages/tokens/test/tokenSchemaValidator.test.js
pnpm-lock.yaml
pnpm-workspace.yaml
tools/transform-tokens-json/README.md
tools/transform-tokens-json/moon.yml
tools/transform-tokens-json/package.json
tools/transform-tokens-json/src/lib/shared.js
tools/transform-tokens-json/src/merge-dark-darkest.js
tools/transform-tokens-json/src/merge-spectrum-express.js
tools/transform-tokens-json/test/index.test.js

@mrcjhicks mrcjhicks changed the title feat: remove duplicate token set definitions feat: remove duplicate token set definitions (S2) Feb 1, 2024
@mrcjhicks mrcjhicks marked this pull request as ready for review February 2, 2024 17:58
@GarthDB GarthDB merged commit f004b0c into beta Feb 2, 2024
3 checks passed
@GarthDB GarthDB deleted the issue/issue--s2-token-set-cleanup branch February 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants