Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prepare script to update cli hardcoded version number #430

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 9, 2024

Description

It's tricky to read in the package json file version number for the cli to return for tdiff --version. I added a prepare script to the package json that will find and replace the hardcoded version number in the src/lib/cli.js file.

How Has This Been Tested?

Locally only. We won't be able to know if it's working for sure without publishing the package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 185c57e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/token-diff-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Oct 9, 2024

Run report for 185c57e7

Total time: 13s | Comparison time: 13.8s | Estimated savings: 776.3ms (5.6% faster)

Action Time Status Info
🟩 SyncWorkspace 5.2ms Passed
⬛️ SetupToolchain(node:~20.12) 2.1s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 6.2s Passed
🟩 RunTask(diff:diff) 103.6ms Passed
🟩 RunTask(root:test) 1.7s Passed
🟩 RunTask(diff:test) 4.8s Passed
Touched files
.changeset/forty-moons-train.md
tools/diff-generator/package.json
tools/diff-generator/src/lib/cli.js
tools/diff-generator/test/cli.test.js
tools/diff-generator/update-version.js

@GarthDB GarthDB requested a review from mrcjhicks October 9, 2024 23:21
@GarthDB GarthDB merged commit fccd972 into main Oct 9, 2024
4 checks passed
@GarthDB GarthDB deleted the garthdb/cli-version-fix branch October 9, 2024 23:35
@GarthDB GarthDB mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants