test: migrate all defineElement tests into base

adobe · Apr 27, 2023 · 73f79ab · 73f79ab
1 parent 07e5019
commit 73f79ab
Show file tree

Hide file tree

Showing 66 changed files with 163 additions and 519 deletions.
diff --git a/packages/asset/test/asset.test.ts b/packages/asset/test/asset.test.ts
@@ -13,10 +13,7 @@ governing permissions and limitations under the License.
 import { elementUpdated, expect, fixture } from '@open-wc/testing';
 
 import { Asset } from '@spectrum-web-components/asset';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers';
+import { testForLitDevWarnings } from '../../../test/testing-helpers';
 import { Default, File, Folder } from '../stories/asset.stories.js';
 
 describe('Asset', () => {
@@ -42,8 +39,4 @@ describe('Asset', () => {
 
  await expect(el).to.be.accessible();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-asset.js'))
- );
 });
diff --git a/packages/avatar/test/avatar.test.ts b/packages/avatar/test/avatar.test.ts
@@ -11,10 +11,7 @@ governing permissions and limitations under the License.
 import '@spectrum-web-components/avatar/sp-avatar.js';
 import { Avatar } from '@spectrum-web-components/avatar';
 import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers';
+import { testForLitDevWarnings } from '../../../test/testing-helpers';
 
 describe('Avatar', () => {
  testForLitDevWarnings(
@@ -114,8 +111,4 @@ describe('Avatar', () => {
  }).to.throw('There should be no error.');
  }
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-avatar.js'))
- );
 });
diff --git a/packages/badge/test/badge.test.ts b/packages/badge/test/badge.test.ts
@@ -16,10 +16,7 @@ import '@spectrum-web-components/badge/sp-badge.js';
 import '@spectrum-web-components/icons-workflow/icons/sp-icon-checkmark-circle.js';
 import { stub } from 'sinon';
 import { Badge } from '../src/Badge.js';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('Badge', () => {
  testForLitDevWarnings(
@@ -152,8 +149,4 @@ describe('Badge', () => {
  });
  });
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-badge.js'))
- );
 });
diff --git a/packages/banner/test/banner.test.ts b/packages/banner/test/banner.test.ts
@@ -11,7 +11,6 @@ governing permissions and limitations under the License.
 import '@spectrum-web-components/banner/sp-banner.js';
 import { Banner } from '@spectrum-web-components/banner';
 import { expect, fixture, html } from '@open-wc/testing';
-import { warnsOnDoubleRegister } from '../../../test/testing-helpers.js';
 
 describe('banner', () => {
  let testDiv!: HTMLDivElement;
@@ -93,8 +92,4 @@ describe('banner', () => {
  expect(el.textContent).to.include('Header Text');
  expect(el.textContent).to.include('Content');
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-banner.js'))
- );
 });
diff --git a/packages/button-group/test/button-group.test.ts b/packages/button-group/test/button-group.test.ts
@@ -15,10 +15,7 @@ import { elementUpdated, expect, fixture } from '@open-wc/testing';
 import '@spectrum-web-components/button-group/sp-button-group.js';
 import { ButtonGroup } from '..';
 import { buttons, buttonsVertical } from '../stories/button-group.stories.js';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('Buttongroup', () => {
  testForLitDevWarnings(
@@ -40,8 +37,4 @@ describe('Buttongroup', () => {
 
  await expect(el).to.be.accessible();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-button-group.js'))
- );
 });
diff --git a/packages/button/test/button.test.ts b/packages/button/test/button.test.ts
@@ -22,7 +22,6 @@ import {
 import {
  shiftTabEvent,
  testForLitDevWarnings,
- warnsOnDoubleRegister,
 } from '../../../test/testing-helpers.js';
 import { spy } from 'sinon';
 
@@ -563,8 +562,4 @@ describe('Button', () => {
  expect(el.variant).to.equal('accent');
  });
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-button.js'))
- );
 });
diff --git a/packages/card/test/card.test.ts b/packages/card/test/card.test.ts
@@ -26,10 +26,7 @@ import {
 } from '../stories/card.stories.js';
 import { Checkbox } from '@spectrum-web-components/checkbox/src/Checkbox';
 import { spy } from 'sinon';
-import {
- spaceEvent,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { spaceEvent } from '../../../test/testing-helpers.js';
 import { sendMouse } from '../../../test/plugins/browser.js';
 import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
@@ -440,8 +437,4 @@ describe('card', () => {
  'the slotted content renders in the element'
  );
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-card.js'))
- );
 });
diff --git a/packages/checkbox/test/checkbox.test.ts b/packages/checkbox/test/checkbox.test.ts
@@ -21,10 +21,7 @@ import {
  waitUntil,
 } from '@open-wc/testing';
 import '@spectrum-web-components/shared/src/focus-visible.js';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 function inputForCheckbox(checkbox: Checkbox): HTMLInputElement {
  if (!checkbox.shadowRoot) throw new Error('No shadowRoot');
@@ -207,8 +204,4 @@ describe('Checkbox', () => {
 
  expect(el.checked).to.be.true;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-checkbox.js'))
- );
 });
diff --git a/packages/coachmark/test/coachmark.test.ts b/packages/coachmark/test/coachmark.test.ts
@@ -14,10 +14,7 @@ import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
 
 import '@spectrum-web-components/coachmark/sp-coachmark.js';
 import { Coachmark } from '@spectrum-web-components/coachmark';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('Coachmark', () => {
  testForLitDevWarnings(
@@ -39,8 +36,4 @@ describe('Coachmark', () => {
 
  await expect(el).to.be.accessible();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-coachmark.js'))
- );
 });
diff --git a/packages/color-area/test/color-area.test.ts b/packages/color-area/test/color-area.test.ts
@@ -25,10 +25,7 @@ import { ColorArea } from '@spectrum-web-components/color-area';
 import { sendKeys } from '@web/test-runner-commands';
 import { spy } from 'sinon';
 import { ColorHandle } from '@spectrum-web-components/color-handle';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('ColorArea', () => {
  testForLitDevWarnings(
@@ -776,8 +773,4 @@ describe('ColorArea', () => {
  el.color = '#f3af';
  expect(el.color).to.equal('#ff33aaff');
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-color-area.js'))
- );
 });
diff --git a/packages/color-handle/test/color-handle.test.ts b/packages/color-handle/test/color-handle.test.ts
@@ -14,10 +14,7 @@ import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
 
 import '@spectrum-web-components/color-handle/sp-color-handle.js';
 import { ColorHandle } from '@spectrum-web-components/color-handle';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('ColorHandle', () => {
  testForLitDevWarnings(
@@ -109,8 +106,4 @@ describe('ColorHandle', () => {
 
  expect(el.open).to.be.false;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-color-handle.js'))
- );
 });
diff --git a/packages/color-loupe/test/color-loupe.test.ts b/packages/color-loupe/test/color-loupe.test.ts
@@ -14,10 +14,7 @@ import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
 
 import '@spectrum-web-components/color-loupe/sp-color-loupe.js';
 import { ColorLoupe } from '@spectrum-web-components/color-loupe';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('ColorLoupe', () => {
  testForLitDevWarnings(
@@ -39,8 +36,4 @@ describe('ColorLoupe', () => {
 
  await expect(el).to.be.accessible();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-color-loupe.js'))
- );
 });
diff --git a/packages/color-slider/test/color-slider.test.ts b/packages/color-slider/test/color-slider.test.ts
@@ -21,7 +21,6 @@ import {
  arrowUpEvent,
  arrowUpKeyupEvent,
  testForLitDevWarnings,
- warnsOnDoubleRegister,
 } from '../../../test/testing-helpers.js';
 
 import '@spectrum-web-components/color-slider/sp-color-slider.js';
@@ -788,8 +787,4 @@ describe('ColorSlider', () => {
  expect(el.value).to.equal(hue);
  expect(tinyHSLA.equals(el.color)).to.be.true;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-color-slider.js'))
- );
 });
diff --git a/packages/color-wheel/test/color-wheel.test.ts b/packages/color-wheel/test/color-wheel.test.ts
@@ -22,7 +22,6 @@ import {
  arrowUpKeyupEvent,
  ignoreResizeObserverLoopError,
  testForLitDevWarnings,
- warnsOnDoubleRegister,
 } from '../../../test/testing-helpers.js';
 
 import '@spectrum-web-components/color-wheel/sp-color-wheel.js';
@@ -617,8 +616,4 @@ describe('ColorWheel', () => {
  expect(el.value).to.equal(hue);
  expect(tinyHSLA.equals(el.color)).to.be.true;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-color-wheel.js'))
- );
 });
diff --git a/packages/dialog/test/dialog-base.test.ts b/packages/dialog/test/dialog-base.test.ts
@@ -29,7 +29,6 @@ import '@spectrum-web-components/overlay/overlay-trigger.js';
 import { alertDestructive } from '../stories/dialog.stories.js';
 import { Button } from '@spectrum-web-components/button/src/Button.js';
 import { DialogBase } from '@spectrum-web-components/dialog';
-import { warnsOnDoubleRegister } from '../../../test/testing-helpers.js';
 
 async function styledFixture<T extends Element>(
  story: TemplateResult
@@ -152,8 +151,4 @@ describe('dialog base', () => {
 
  expect(dialog.open).to.be.false;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-dialog-base.js'))
- );
 });
diff --git a/packages/dialog/test/dialog-wrapper.test.ts b/packages/dialog/test/dialog-wrapper.test.ts
@@ -41,10 +41,7 @@ import {
 import { OverlayTrigger } from '@spectrum-web-components/overlay';
 import { html, TemplateResult } from '@spectrum-web-components/base';
 import { Theme } from '@spectrum-web-components/theme';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 import { Divider } from '@spectrum-web-components/divider/src/Divider.js';
 
 async function styledFixture<T extends Element>(
@@ -341,8 +338,4 @@ describe('Dialog Wrapper', () => {
  });
  consoleWarnStub.restore();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-dialog-wrapper.js'))
- );
 });
diff --git a/packages/dialog/test/dialog.test.ts b/packages/dialog/test/dialog.test.ts
@@ -28,10 +28,7 @@ import {
  small,
 } from '../stories/dialog.stories.js';
 import { spy } from 'sinon';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('Dialog', () => {
  testForLitDevWarnings(async () => await fixture<Dialog>(small()));
@@ -241,8 +238,4 @@ describe('Dialog', () => {
  const container = el.shadowRoot.querySelector('#dismiss-container');
  expect(container).to.not.be.null;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-dialog.js'))
- );
 });
diff --git a/packages/divider/test/divider.test.ts b/packages/divider/test/divider.test.ts
@@ -14,10 +14,7 @@ import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
 
 import '@spectrum-web-components/divider/sp-divider.js';
 import { Divider } from '@spectrum-web-components/divider';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('Divider', () => {
  testForLitDevWarnings(
@@ -50,8 +47,4 @@ describe('Divider', () => {
 
  await expect(el).to.be.accessible();
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-divider.js'))
- );
 });
diff --git a/packages/dropzone/test/dropzone.test.ts b/packages/dropzone/test/dropzone.test.ts
@@ -12,10 +12,7 @@ governing permissions and limitations under the License.
 import '@spectrum-web-components/dropzone/sp-dropzone.js';
 import { Dropzone } from '@spectrum-web-components/dropzone';
 import { illustration } from './test-svg.js';
-import {
- waitForPredicate,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { waitForPredicate } from '../../../test/testing-helpers.js';
 import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
 
 describe('Dropzone', () => {
@@ -190,8 +187,4 @@ describe('Dropzone', () => {
 
  expect(dropped).to.be.true;
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-dropzone.js'))
- );
 });
diff --git a/packages/field-group/test/field-group.test.ts b/packages/field-group/test/field-group.test.ts
@@ -17,10 +17,7 @@ import { FieldGroup } from '@spectrum-web-components/field-group';
 import '@spectrum-web-components/help-text/sp-help-text.js';
 import '@spectrum-web-components/checkbox/sp-checkbox.js';
 import '@spectrum-web-components/field-group/sp-field-group.js';
-import {
- testForLitDevWarnings,
- warnsOnDoubleRegister,
-} from '../../../test/testing-helpers.js';
+import { testForLitDevWarnings } from '../../../test/testing-helpers.js';
 
 describe('FieldGroup', () => {
  testForLitDevWarnings(
@@ -134,8 +131,4 @@ describe('FieldGroup', () => {
  await findDescribedNode(name, descriptionNegative);
  });
  });
- describe(
- 'dev mode registration',
- warnsOnDoubleRegister(() => import('../sp-field-group.js'))
- );
 });