Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oddly shaped focus outline when opening sp-dialog #1133

Closed
davidclark87 opened this issue Jan 22, 2021 · 1 comment · Fixed by #1147
Closed

Oddly shaped focus outline when opening sp-dialog #1133

davidclark87 opened this issue Jan 22, 2021 · 1 comment · Fixed by #1147

Comments

@davidclark87
Copy link
Collaborator

davidclark87 commented Jan 22, 2021

Expected Behaviour

I wouldn't expect to see a focus outline around a newly opened dialog. If we are deliberately showing this outline for accessibility purposes, I'd expect it to closely wrap the contours of the dialog rather than extend across the full viewport width. FWIW, React Spectrum dialogs don't have such an outline.

Actual Behaviour

"Small" example on docs site:
image

Fullscreen mode example (Fullscreen takeover mode exhibits same behavior, but the outline is eventually covered by the dialog once the opening animation completes):
image

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper/examples
  2. Click any of the "Toggle dialog" buttons on that page (e.g. the "Small" example)

Platform and Version

Tested on Mac: Occurs on Chrome and Edge; does not occur on Safari or Firefox.
Not tested on Windows.

Sample Code that illustrates the problem

See docs site

Logs taken while reproducing problem

N/A

@davidclark87
Copy link
Collaborator Author

@Westbrook I noticed a couple other issues in this area on the same Chromium browsers - please let me know if you'd rather I filed a separate bug for either:

  1. Clicking just to the right of the Toggle Dialog button (rather than clicking the button itself) results in an unexpected focus outline being displayed:
    image

  2. The fading in/out of the modal scrim is quite slow and clunky compared to Safari/Firefox

Not sure if related, but I hit this when taking a look at the fix for #1037 (which looks good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants