You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wouldn't expect to see a focus outline around a newly opened dialog. If we are deliberately showing this outline for accessibility purposes, I'd expect it to closely wrap the contours of the dialog rather than extend across the full viewport width. FWIW, React Spectrum dialogs don't have such an outline.
Fullscreen mode example (Fullscreen takeover mode exhibits same behavior, but the outline is eventually covered by the dialog once the opening animation completes):
@Westbrook I noticed a couple other issues in this area on the same Chromium browsers - please let me know if you'd rather I filed a separate bug for either:
Clicking just to the right of the Toggle Dialog button (rather than clicking the button itself) results in an unexpected focus outline being displayed:
The fading in/out of the modal scrim is quite slow and clunky compared to Safari/Firefox
Not sure if related, but I hit this when taking a look at the fix for #1037 (which looks good)
Expected Behaviour
I wouldn't expect to see a focus outline around a newly opened dialog. If we are deliberately showing this outline for accessibility purposes, I'd expect it to closely wrap the contours of the dialog rather than extend across the full viewport width. FWIW, React Spectrum dialogs don't have such an outline.
Actual Behaviour
"Small" example on docs site:
![image](https://user-images.githubusercontent.com/15110225/105427611-5e7ef280-5c02-11eb-8d88-77b3d6cf3dba.png)
Fullscreen mode example (Fullscreen takeover mode exhibits same behavior, but the outline is eventually covered by the dialog once the opening animation completes):
![image](https://user-images.githubusercontent.com/15110225/105427622-65a60080-5c02-11eb-83d3-9f699b95cc83.png)
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Tested on Mac: Occurs on Chrome and Edge; does not occur on Safari or Firefox.
Not tested on Windows.
Sample Code that illustrates the problem
See docs site
Logs taken while reproducing problem
N/A
The text was updated successfully, but these errors were encountered: