Overlay review updates.

[Westbrook]

Description

• ensure [focusable] can be passed focus
• remove focus outline on ActiveOverlay
• use aria-hidden="true" on content that prevents tab access
• have overlay-stack set content.open = true rather than rely on implementor
• allow "hover" content to be trigged via focusin/out

Related Issue

fixes #1133

Motivation and Context

Accessibility, predictability, simplicity, correctness.

How Has This Been Tested?

Manually at https://60108127101bb4010c2b6208--spectrum-web-components.netlify.app/components/dialog-wrapper

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[najikahalsema]

Nice!

[adixon-adobe]

@Westbrook what's up with the footer font color there?

[Westbrook]

@adixon-adobe looks like this got either removed or overlooked at the Spectrum CSS level at some point. The content is available in the CSS, though it doesn't not have styling for the color property, but not present in any of the HTML examples. I'd like to follow up on this separately, as this is currently what is in production: https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper 🙈 Thoughts?

[adixon-adobe]

@Westbrook can you just file a followup issue? I don't think you need to hold this change up, but you did post a screenshot with an obvious issue ;-)

[Westbrook]

Well, in comparison: 😜

I've added #1149 to track!