Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp-tabs should be left-aligned in horizontal layout #1135

Closed
adixon-adobe opened this issue Jan 22, 2021 · 4 comments · Fixed by #1666
Closed

sp-tabs should be left-aligned in horizontal layout #1135

adixon-adobe opened this issue Jan 22, 2021 · 4 comments · Fixed by #1666

Comments

@adixon-adobe
Copy link
Collaborator

Expected Behaviour

The tabs should look like the design without any padding on the left.

Actual Behaviour

There's a little left padding which you can see in the border bottom.

Related CSS issue: adobe/spectrum-css#1107

@Westbrook
Copy link
Contributor

Interest. Does the source reference the usage of the focus ring when fully left aligned like that?

image

Do you thoughts on SWC doing anything ahead of CSS addressing this?

@adixon-adobe
Copy link
Collaborator Author

I'd at least expect the focus ring to go beyond the bottom border, but it seems like we should get some design guidance here. Do you know if focus rings are affected by overflow:hidden;? If not, I could see just adding some notes to the docs to make sure you leave space for them.

@adixon-adobe
Copy link
Collaborator Author

Following up:

My expectation (assuming the focus ring requires that space) is that the bottom border would stop where the text is (not where the focus ring extends). It'd also be nice to have access to a custom property for the left padding since we have a few places where we need to shift this so it's left-aligned with other controls that don't have similar wide focus rings.

@Westbrook
Copy link
Contributor

Preview: Preview: https://westbrook-dna-7--spectrum-web-components.netlify.app/storybook/index.html?path=/story/tabs-sizes--s

Would we expect a custom property that allowed consumers to "update" this delivery to align with what was previously the default?

@Westbrook Westbrook pinned this issue Aug 18, 2021
@Westbrook Westbrook added the P1 label Sep 10, 2021
@Westbrook Westbrook unpinned this issue Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants