Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizontal tabs are improperly indented #1107

Closed
adixon-adobe opened this issue Jan 22, 2021 · 5 comments
Closed

horizontal tabs are improperly indented #1107

adixon-adobe opened this issue Jan 22, 2021 · 5 comments
Labels
bug Results from a bug in the CSS implementation

Comments

@adixon-adobe
Copy link
Contributor

Description

Compare the SpectrumCSS implementation to the design

Horizontal tabs should be left-aligned, but the text of the tabs is indented. The underline is no longer indented, which looks bad because of the discrepency

Expected behavior

SpectrumCSS should match the designs

Environment

Tested on Chrome Mac
@adixon-adobe adixon-adobe added the bug Results from a bug in the CSS implementation label Jan 22, 2021
@adixon-adobe adixon-adobe mentioned this issue Jan 22, 2021
Closed
@charlessuh
Copy link

Screen Shot 2021-08-10 at 12 08 39 PM

pfulton added a commit that referenced this issue Aug 17, 2021
@pfulton
fix(tabs): remove improper indentation for horizontal tabs
e3388f4 
This fixes #1107, by removing the left and right padding properties.
GarthDB pushed a commit that referenced this issue Aug 17, 2021
@pfulton @GarthDB
fix(tabs): remove improper indentation for horizontal tabs
79b7a82 
This fixes #1107, by removing the left and right padding properties.
@pfulton
Copy link
Collaborator

pfulton commented Aug 17, 2021

This should be fixed in 79b7a82.

@pfulton pfulton closed this as completed Aug 17, 2021
@adixon-adobe
Copy link
Contributor Author

@pfulton is there a place I can preview this fix?

@GarthDB
Copy link
Member

GarthDB commented Aug 18, 2021

@adixon-adobe you can check it out locally. Our automated build is currently down. It's in the DNA-7.0-beta branch.

@adixon-adobe
Copy link
Contributor Author

adixon-adobe commented Aug 18, 2021 •
edited
Loading

@Westbrook sent me a SWC link with these changes (and t-shirt sizing) that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@charlessuh @GarthDB @lazd @pfulton @adixon-adobe