Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Overlay] Control when work is done #1512

Closed
Westbrook opened this issue Jun 7, 2021 · 0 comments · Fixed by #1682
Closed

[Overlay] Control when work is done #1512

Westbrook opened this issue Jun 7, 2021 · 0 comments · Fixed by #1682
Labels
Component: Overlay Performance

Comments

@Westbrook
Copy link
Contributor

We can control when work is done, while also allowing pre-<body> loading of JS (if required) by revisiting when these events are added in support of the overlay stack.

spectrum-web-components/packages/overlay/src/overlay-stack.ts

Lines 154 to 159 in 1ffdbe1

private addEventListeners(): void {
this.document.addEventListener('click', this.handleMouseCapture, true);
this.document.addEventListener('click', this.handleMouse);
this.document.addEventListener('keyup', this.handleKeyUp);
window.addEventListener('resize', this.handleResize);
} 

private get document(): Document {
    return this.root.ownerDocument /* c8 ignore next */ || document;
}

The this.document values resolve to undefined when run before <body> preventing page blocking JS loading techniques.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Overlay Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update when events are added to manage overlays adobe/spectrum-web-components
1 participant
@Westbrook