fix: update when events are added to manage overlays #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch Preview URLsWhen a visual regression test fails (or has previously failed while working on this branch), its results will be avaialable at the associated URL below:
|
Tachometer results for changed packagesaction-bar permalink
action-menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
najikahalsema
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only listen for overlay events when an overlay is actually open.
Related Issue
fixes #1512
Motivation and Context
Allow for inclusion of the code before the
<body>tag. Make the code more performant to boot up.How Has This Been Tested?
Types of changes
Checklist: