Add Tachometer Benchmarking #103
Conversation
Westbrook
force-pushed
the
westbrook/CRISP-1165/tachometer
branch
from
1721089
to
1ca5b04
Compare
test/benchmark/cli.ts
Outdated
| $ node test/benchmark/cli | ||
| Run all benchmarks for specific components: | ||
| $ node test/benchmark/cli -p button ripple | ||
| $ node test/benchmark/cli -p button -p ripple |
There was a problem hiding this comment.
Is this referring to a ripple component we're probably never going to have?
There was a problem hiding this comment.
It may be that a I copped much of this file (the whole file...) from a project that has such a component. Updating to a component me might have int eh future.
test/benchmark/slider/test-basic.ts
Outdated
| max="100" | ||
| label="Opacity" | ||
| id="opacity-slider" | ||
| /> |
There was a problem hiding this comment.
I didn't think you could have self closing custom elements?
There was a problem hiding this comment.
You are catching all my copy/paste errors, yay! Updating the stories that this snippet came from. Looking into something like https://medium.com/storybookjs/component-story-format-66f4c32366df for the mono-repo to reduce our dependency on internally repeated code.
There was a problem hiding this comment.
Thats pretty cool, would be great to be able to have a 'benchmark' story that defines the tachometer fixture.
There was a problem hiding this comment.
Discussed offline to resolve tsconfig issues, assuming there's a change incoming for the updated config that resulted from that conversation. I'm going to approve now, but lets get someone else to run this since I was not able to run this under WSL at this time due to not being able to set the chrome binary path, this is being tracked by the tachometer team here: google/tachometer#70
|
Thanks @benjamind, I also added the |
Description
Adds basic tachometer benchmarking to the various components
Future Work
Motivation and Context
We want to know, maintain, and compare the performance of our components over the course on various additions and this will help clarify a specific numeric metric to describe the performance thereof.
How Has This Been Tested?
npm run build:tests && npm run test:benchmakes the tests run non-comparatively across all of the components.Screenshots (if appropriate):
Types of changes
Checklist: