-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andrew/card component #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an excellent first implementation. Couple of minor comments. I think we should move subtitle text into an attribute since it probably shouldn't be rich content and is more inline with title text then, other than that looks good. Though we do need to setup dynamic rendering for changing of attributes since we don't get that without the use of lit-element, but thats a task for another day.
Add spectrum card component and some of its variations.
Description
Add spectrum card, gallery card, and quiet card. Add a demo page showcasing each component
Motivation and Context
Decided to start with a simple component as a POC. The card component was a good choice since it takes in dynamic content but was relatively simple.
How Has This Been Tested?
Testing of the component variations was done through the the card demo page.
Screenshots (if appropriate):
Types of changes
Checklist: