Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrew/card component #2

Merged
merged 15 commits into from
Jan 9, 2019
Merged

Andrew/card component #2

merged 15 commits into from
Jan 9, 2019

Conversation

andrewhatran
Copy link
Collaborator

Add spectrum card component and some of its variations.

Description

Add spectrum card, gallery card, and quiet card. Add a demo page showcasing each component

Motivation and Context

Decided to start with a simple component as a POC. The card component was a good choice since it takes in dynamic content but was relatively simple.

How Has This Been Tested?

Testing of the component variations was done through the the card demo page.

Screenshots (if appropriate):

screen shot 2019-01-07 at 1 10 57 pm

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@benjamind benjamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent first implementation. Couple of minor comments. I think we should move subtitle text into an attribute since it probably shouldn't be rich content and is more inline with title text then, other than that looks good. Though we do need to setup dynamic rendering for changing of attributes since we don't get that without the use of lit-element, but thats a task for another day.

src/components/banner/demo/index.html Outdated Show resolved Hide resolved
src/styles/theme-dark/components/card.css Outdated Show resolved Hide resolved
src/styles/theme-light/components/card.css Outdated Show resolved Hide resolved
src/components/card/card-gallery.ts Outdated Show resolved Hide resolved
src/components/card/demo/index.html Outdated Show resolved Hide resolved
src/components/card/demo/index.html Outdated Show resolved Hide resolved
@andrewhatran andrewhatran merged commit 1d8f757 into master Jan 9, 2019
@andrewhatran andrewhatran deleted the andrew/card-component branch January 14, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants