fix: match "pointerup" listeners with "pointercancel" for full coverage #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
pointercancel
branch
from
271aaa0
to
6eb873f
Compare
hunterloftis
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
It's such a pity to have to lift the responsibility for all this pointer-state handling into JS. I know this was re: a browser bug... maybe something we could track to subsequently cut all of this?
One other approach to consider, now that the bookkeeping list is getting pretty large, is using an AbortController signal to remove batches of event listeners instead of having to manually keep them in sync.
|
Yeah, for larger number of matched listeners #1877 does make a lot of sense. Some of these are JS first problems, others (like synthetic |
Tachometer resultsChromeaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
button permalink
card permalink
dialog permalink
menu permalink
number-field permalink
overlay permalink
picker permalink
popover permalink
search permalink
slider permalink
split-button permalink
tags permalink
toast permalink
tooltip permalink
Firefoxaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
button permalink
card permalink
dialog permalink
menu permalink
number-field permalink
overlay permalink
picker permalink
popover permalink
search permalink
slider permalink
split-button permalink
tags permalink
toast permalink
tooltip permalink
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure all
pointeruplisteners are matched with apointercancellistener in case the visitor proceeds to scroll while the pointer is down.How has this been tested?
Types of changes
Checklist