Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox): add size attribute #3887

Merged
merged 4 commits into from
Dec 19, 2023
Merged

feat(combobox): add size attribute #3887

merged 4 commits into from
Dec 19, 2023

Conversation

najikahalsema
Copy link
Collaborator

@najikahalsema najikahalsema commented Dec 19, 2023 •
edited
Loading

Description

Added size attribute to combobox. The one thing I wasn't sure about was passing the size down to the child sp-menu-items, because sp-menu does that work already, but I think that should be okay.

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1
    1. Go here
    2. See that for each story, the elements are sized appropriately.
  • Test case 2
    1. Review VRTs

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions GitHub Actions
Copy link

Branch Preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

Tachometer results

Currently, no packages are changed by this PR...

@najikahalsema najikahalsema force-pushed the combobox-sizes branch 2 times, most recently from e8c491b to d35fa93 Compare December 19, 2023 20:01
@najikahalsema najikahalsema added in-review Label to trigger PR auto Update from main and removed in-review Label to trigger PR auto Update from main labels Dec 19, 2023
This was referenced Dec 19, 2023
Closed
Closed
Westbrook
Westbrook approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@najikahalsema najikahalsema merged commit 22c1088 into combobox Dec 19, 2023
6 of 7 checks passed
@najikahalsema najikahalsema deleted the combobox-sizes branch December 19, 2023 21:42
Westbrook added a commit that referenced this pull request Jan 4, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
e7a5a39 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 6, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
fc6c9c5 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 9, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
d881b61 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 11, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
4bd227d 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 18, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
f8d2a70 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
najikahalsema added a commit that referenced this pull request Jan 18, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
451ebdb 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 25, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
3306931 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook added a commit that referenced this pull request Jan 31, 2024
@najikahalsema @Westbrook
feat(combobox): add size attribute (#3887)
5716991 
* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Westbrook pushed a commit that referenced this pull request Feb 2, 2024
@najikahalsema @hunterloftis
fix(combobox): add combobox pattern (#3894)
47d7d71 
* feat(combobox): begin working branch for combobox additions

* feat(combobox): add size attribute (#3887)

* feat(combobox): wip

* chore: update sizes and stories

* chore: add isoverlayopen decorator to stories

---------

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>

* chore: add benchmark test for lightdom combobox (#3898)

* chore: add benchmark test for lightdom combobox

* chore: add object version of benchmark test

* chore: rename files

---------

Co-authored-by: Najika Yoo <naj.halsema@gmail.com>

* test(combobox): update data management tests for current API

* test(combobox): get more tests passing and skip tests that will be visited in future work (#3919)

* test(combobox): get more tests passing and skip tests that will be visited in future work

* ci: update golden images cache

* test(combobox): ignore Combobox Item code

* chore(combobox): cleanup unused code (#3922)

* chore(combobox): cleanup unused code

* ci: update golden images cache

* fix(combobox): add support for external tooltip elements (#3930)

* fix(combobox): add support for external tooltip elements

* chore(combobox): remove unused code paths

* ci: update golden images cache

* docs(combobox): include slot present in API docs

* fix(combobox): allow intern Menu to hold a selection when autocomplete === "none" (#3951)

* test(combobox): add accessibility tests (#3953)

* chore: add labels to combobox input

* chore: get tests passing

* test(combobox): get a11y tests passing

* chore: remove unused positionlistbox method

* test: get tests passing, change spelling of activeDescendant

* chore: missed some descendents

* chore: add help text demo and test

* ci: update hash

* chore: address review comments

* chore: abstract shared data to index files

* test(combobox): update tests and stories to use legible data

* ci: update hash

* chore: label menu and rename stories

* ci: update hash

---------

Co-authored-by: Najika Yoo <naj.halsema@gmail.com>

* test(combobox): fulfil accessibility contract (#3974)

* chore: add tooltip to ariadescribedby

* test(combobox): add a11y test for tooltip

---------

Co-authored-by: Najika Yoo <naj.halsema@gmail.com>

* chore(bundle): include combobox

* chore(combobox): clean up property availability and types

* chore(combobox): clean up property availability and type

* refactor(combobox): update ComboboxOption type

* ci: update golden images cache

* refactor(combobox): simplify typing and correct query location when moving items into viewport

* docs: use human useful content in stories

* ci: update golden images cache

* refactor(combobox): default "autocomplete" to "none"

* docs: correct story configuration

* docs(combobox): create initial documentation

* docs(combobox): apply docs feedback

* docs(combobox): use only working examples in live mode

* fix(combobox): maintain focus on input element when toggling menu

* docs(combobox): improve clarity

* ci: update golden images cache

* docs(combobox): add story demonstrating controlled-component usage (#3988)

* docs(combobox): add story demonstrating controlled-component usage

* Update packages/combobox/stories/combobox.stories.ts

Co-authored-by: Westbrook Johnson <wesjohns@adobe.com>

---------

Co-authored-by: Westbrook Johnson <wesjohns@adobe.com>

* fix(combobox): add support for "readonly" and "disabled"

* docs(textfield): expand on attribute/property descriptions

* fix(combobox): add support for "readonly" and "disabled"

* ci: update golden images cache

* fix(textfield): prevent outline on :focus-visible elements that are disabled

* fix(combobox): correct value to itemText interchange when something is "selected" (#3994)

---------

Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Co-authored-by: Hunter Loftis <hunter@hunterloftis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@najikahalsema @Westbrook