Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add 'system' context to sp-theme #4755

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: add 'system' context to sp-theme #4755

wants to merge 14 commits into from

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Sep 16, 2024 •
edited
Loading

Description

This PR adds a systemContext functionality to the <sp-theme> component, enabling descendant components to consume the system context in a reusable manner.

Motivation and context

Added aSystemResolutionController to encapsulate the logic for requesting and receiving the system context.

Updated the sp-theme README with instructions on how to consume the system context using the controller.

How has this been tested?

Integrated these changes in the IconBase on the S2 icon delivery to test its reactivity.
Unit tests WIP.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Base automatically changed from ruben/chore-theme-refactor to main September 17, 2024 13:12
Rajdeepc
Rajdeepc requested changes Sep 25, 2024
View reviewed changes
packages/icon/src/Icon.ts Outdated Show resolved Hide resolved
tools/theme/test/theme-devmode.test.ts Outdated Show resolved Hide resolved
packages/icon/src/Icon.ts Outdated Show resolved Hide resolved
tools/theme/src/Theme.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11041260313

Details

  • 156 of 159 (98.11%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 98.199%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/theme/src/Theme.ts 67 70 95.71%
Totals Coverage Status
Change from base Build 11028589290: -0.01%
Covered Lines: 32704
Relevant Lines: 33126
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.213 kB 216.74 kB 🏆 216.836 kB
Scripts 57.477 kB 51.997 kB 🏆 52.295 kB
Stylesheet 34.758 kB 30.238 kB 30.109 kB 🏆
Document 6.224 kB 5.46 kB 🏆 5.466 kB
Font 126.93 kB 126.596 kB 🏆 126.615 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 82.63ms - 84.71ms - faster ✔
15% - 18%
14.99ms - 17.79ms
branch 408 kB 99.12ms - 100.99ms slower ❌
18% - 21%
14.99ms - 17.79ms		 -

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 53.03ms - 55.76ms - faster ✔
5% - 12%
2.66ms - 7.52ms
branch 478 kB 57.48ms - 61.50ms slower ❌
5% - 14%
2.66ms - 7.52ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 71.55ms - 72.95ms - faster ✔
11% - 14%
9.32ms - 11.62ms
branch 520 kB 81.81ms - 83.63ms slower ❌
13% - 16%
9.32ms - 11.62ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 48.35ms - 50.62ms - faster ✔
3% - 8%
1.49ms - 4.20ms
branch 543 kB 51.59ms - 53.07ms slower ❌
3% - 9%
1.49ms - 4.20ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 138.19ms - 141.10ms - faster ✔
7% - 10%
10.27ms - 14.59ms
branch 661 kB 150.48ms - 153.67ms slower ❌
7% - 11%
10.27ms - 14.59ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 66.96ms - 68.28ms - faster ✔
10% - 12%
7.16ms - 9.14ms
branch 617 kB 75.03ms - 76.51ms slower ❌
11% - 14%
7.16ms - 9.14ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 66.12ms - 67.19ms - faster ✔
8% - 11%
6.13ms - 7.93ms
branch 616 kB 72.96ms - 74.41ms slower ❌
9% - 12%
6.13ms - 7.93ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1871.73ms - 1874.52ms - unsure 🔍
-0% - +0%
-3.79ms - +0.11ms
branch 804 kB 1873.60ms - 1876.32ms unsure 🔍
-0% - +0%
-0.11ms - +3.79ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1878.08ms - 1880.91ms - unsure 🔍
-0% - +0%
-0.98ms - +3.07ms
branch 802 kB 1877.00ms - 1879.89ms unsure 🔍
-0% - +0%
-3.07ms - +0.98ms		 -

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 12.06ms - 12.30ms - faster ✔
2% - 4%
0.19ms - 0.55ms
branch 416 kB 12.42ms - 12.68ms slower ❌
2% - 5%
0.19ms - 0.55ms		 -

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 110.18ms - 111.34ms - faster ✔
1% - 3%
1.39ms - 2.92ms
branch 456 kB 112.42ms - 113.42ms slower ❌
1% - 3%
1.39ms - 2.92ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 516.97ms - 521.18ms - faster ✔
4% - 5%
22.05ms - 29.61ms
branch 677 kB 541.77ms - 548.05ms slower ❌
4% - 6%
22.05ms - 29.61ms		 -

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 44.05ms - 44.95ms - faster ✔
5% - 7%
2.14ms - 3.46ms
branch 447 kB 46.82ms - 47.78ms slower ❌
5% - 8%
2.14ms - 3.46ms		 -

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 48.69ms - 49.51ms - faster ✔
7% - 9%
3.79ms - 5.10ms
branch 454 kB 53.03ms - 54.05ms slower ❌
8% - 10%
3.79ms - 5.10ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 38.18ms - 39.02ms - faster ✔
2% - 5%
0.80ms - 1.95ms
branch 494 kB 39.59ms - 40.36ms slower ❌
2% - 5%
0.80ms - 1.95ms		 -

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 40.05ms - 41.46ms - faster ✔
10% - 15%
4.42ms - 6.93ms
branch 407 kB 45.39ms - 47.47ms slower ❌
11% - 17%
4.42ms - 6.93ms		 -

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 93.20ms - 94.78ms - faster ✔
5% - 7%
4.79ms - 7.41ms
branch 635 kB 99.05ms - 101.14ms slower ❌
5% - 8%
4.79ms - 7.41ms		 -

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 468 kB 128.06ms - 129.15ms - faster ✔
1% - 3%
1.76ms - 3.29ms
branch 446 kB 130.59ms - 131.67ms slower ❌
1% - 3%
1.76ms - 3.29ms		 -

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 41.96ms - 42.58ms - faster ✔
8% - 10%
3.55ms - 4.55ms
branch 479 kB 45.93ms - 46.71ms slower ❌
8% - 11%
3.55ms - 4.55ms		 -

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 110.40ms - 111.18ms - faster ✔
1% - 3%
1.23ms - 2.94ms
branch 448 kB 112.11ms - 113.63ms slower ❌
1% - 3%
1.23ms - 2.94ms		 -

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 106.14ms - 108.28ms - faster ✔
1% - 3%
0.65ms - 2.96ms
branch 449 kB 108.58ms - 109.44ms slower ❌
1% - 3%
0.65ms - 2.96ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 38.59ms - 39.04ms - faster ✔
3% - 5%
1.26ms - 2.13ms
branch 720 kB 40.13ms - 40.88ms slower ❌
3% - 6%
1.26ms - 2.13ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 423.92ms - 428.91ms - faster ✔
1% - 3%
5.32ms - 13.23ms
branch 720 kB 432.62ms - 438.76ms slower ❌
1% - 3%
5.32ms - 13.23ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 50.66ms - 52.09ms - faster ✔
9% - 12%
4.90ms - 6.87ms
branch 646 kB 56.58ms - 57.94ms slower ❌
9% - 13%
4.90ms - 6.87ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 80.70ms - 81.33ms - faster ✔
0% - 2%
0.19ms - 1.32ms
branch 513 kB 81.31ms - 82.25ms slower ❌
0% - 2%
0.19ms - 1.32ms		 -

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 44.40ms - 45.36ms - faster ✔
3% - 6%
1.20ms - 2.89ms
branch 413 kB 46.22ms - 47.62ms slower ❌
3% - 6%
1.20ms - 2.89ms		 -

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 20.61ms - 22.02ms - unsure 🔍
-10% - +0%
-2.27ms - +0.11ms
branch 383 kB 21.44ms - 23.35ms unsure 🔍
-1% - +11%
-0.11ms - +2.27ms		 -

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 40.90ms - 43.59ms - unsure 🔍
-3% - +6%
-1.25ms - +2.39ms
branch 431 kB 40.46ms - 42.90ms unsure 🔍
-6% - +3%
-2.39ms - +1.25ms		 -

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 10.23ms - 10.38ms - faster ✔
3% - 5%
0.30ms - 0.51ms
branch 379 kB 10.63ms - 10.79ms slower ❌
3% - 5%
0.30ms - 0.51ms		 -

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 11.40ms - 11.58ms - faster ✔
14% - 16%
1.95ms - 2.22ms
branch 386 kB 13.46ms - 13.68ms slower ❌
17% - 19%
1.95ms - 2.22ms		 -

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 15.09ms - 15.36ms - faster ✔
7% - 10%
1.18ms - 1.71ms
branch 393 kB 16.44ms - 16.90ms slower ❌
8% - 11%
1.18ms - 1.71ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 212.53ms - 214.88ms - faster ✔
1% - 3%
3.23ms - 6.45ms
branch 472 kB 217.45ms - 219.65ms slower ❌
2% - 3%
3.23ms - 6.45ms		 -

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 48.06ms - 48.66ms - faster ✔
4% - 5%
1.80ms - 2.75ms
branch 398 kB 50.27ms - 50.99ms slower ❌
4% - 6%
1.80ms - 2.75ms		 -

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 68.40ms - 69.32ms - faster ✔
14% - 16%
10.97ms - 13.09ms
branch 516 kB 79.94ms - 81.85ms slower ❌
16% - 19%
10.97ms - 13.09ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 461.90ms - 472.13ms - unsure 🔍
-2% - +1%
-7.69ms - +3.24ms
branch 700 kB 467.32ms - 471.16ms unsure 🔍
-1% - +2%
-3.24ms - +7.69ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 23.99ms - 24.51ms - faster ✔
6% - 9%
1.62ms - 2.38ms
branch 779 kB 25.97ms - 26.53ms slower ❌
7% - 10%
1.62ms - 2.38ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 375.59ms - 379.77ms - faster ✔
2% - 3%
7.70ms - 12.93ms
branch 768 kB 386.42ms - 389.57ms slower ❌
2% - 3%
7.70ms - 12.93ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 42.76ms - 43.43ms - faster ✔
7% - 12%
3.48ms - 5.63ms
branch 564 kB 46.63ms - 48.67ms slower ❌
8% - 13%
3.48ms - 5.63ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 26.16ms - 26.65ms - faster ✔
11% - 14%
3.28ms - 4.16ms
branch 406 kB 29.76ms - 30.49ms slower ❌
12% - 16%
3.28ms - 4.16ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 519.14ms - 526.24ms - faster ✔
1% - 3%
6.54ms - 16.76ms
branch 527 kB 530.66ms - 538.01ms slower ❌
1% - 3%
6.54ms - 16.76ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 11.81ms - 12.88ms - unsure 🔍
-9% - +3%
-1.11ms - +0.39ms
branch 374 kB 12.17ms - 13.23ms unsure 🔍
-3% - +9%
-0.39ms - +1.11ms		 -

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 28.73ms - 29.30ms - faster ✔
3% - 5%
0.77ms - 1.65ms
branch 399 kB 29.90ms - 30.57ms slower ❌
3% - 6%
0.77ms - 1.65ms		 -

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 36.73ms - 37.46ms - faster ✔
1% - 4%
0.29ms - 1.35ms
branch 397 kB 37.53ms - 38.29ms slower ❌
1% - 4%
0.29ms - 1.35ms		 -

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 40.36ms - 41.01ms - faster ✔
8% - 11%
3.36ms - 4.82ms
branch 464 kB 44.12ms - 45.42ms slower ❌
8% - 12%
3.36ms - 4.82ms		 -

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 442 kB 159.14ms - 163.81ms - faster ✔
7% - 9%
11.39ms - 16.45ms
branch 419 kB 174.43ms - 176.37ms slower ❌
7% - 10%
11.39ms - 16.45ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 78.01ms - 79.64ms - faster ✔
4% - 6%
3.01ms - 5.10ms
branch 472 kB 82.22ms - 83.54ms slower ❌
4% - 7%
3.01ms - 5.10ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1866.33ms - 1870.26ms - unsure 🔍
-0% - +0%
-3.32ms - +2.13ms
branch 737 kB 1867.00ms - 1870.78ms unsure 🔍
-0% - +0%
-2.13ms - +3.32ms		 -

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 13.48ms - 13.76ms - faster ✔
7% - 10%
1.06ms - 1.50ms
branch 399 kB 14.73ms - 15.07ms slower ❌
8% - 11%
1.06ms - 1.50ms		 -

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 14.95ms - 15.28ms - faster ✔
4% - 7%
0.66ms - 1.10ms
branch 391 kB 15.84ms - 16.14ms slower ❌
4% - 7%
0.66ms - 1.10ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 122.81ms - 125.49ms - faster ✔
5% - 8%
7.05ms - 10.83ms
branch 498 kB 131.76ms - 134.42ms slower ❌
6% - 9%
7.05ms - 10.83ms		 -

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 117.61ms - 119.07ms - faster ✔
0% - 2%
0.24ms - 2.32ms
branch 416 kB 118.87ms - 120.36ms slower ❌
0% - 2%
0.24ms - 2.32ms		 -

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 12.70ms - 12.94ms - slower ❌
0% - 2%
0.01ms - 0.30ms
branch 442 kB 12.58ms - 12.75ms faster ✔
0% - 2%
0.01ms - 0.30ms		 -

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 24.70ms - 25.23ms - faster ✔
9% - 11%
2.37ms - 3.17ms
branch 425 kB 27.43ms - 28.03ms slower ❌
9% - 13%
2.37ms - 3.17ms		 -

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 28.07ms - 28.47ms - faster ✔
12% - 14%
3.81ms - 4.47ms
branch 422 kB 32.15ms - 32.68ms slower ❌
13% - 16%
3.81ms - 4.47ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 34.95ms - 35.55ms - faster ✔
3% - 6%
1.19ms - 2.13ms
branch 554 kB 36.54ms - 37.27ms slower ❌
3% - 6%
1.19ms - 2.13ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 24.00ms - 24.47ms - faster ✔
7% - 10%
1.89ms - 2.69ms
branch 539 kB 26.20ms - 26.85ms slower ❌
8% - 11%
1.89ms - 2.69ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 53.65ms - 54.72ms - faster ✔
5% - 8%
2.81ms - 4.38ms
branch 661 kB 57.21ms - 58.35ms slower ❌
5% - 8%
2.81ms - 4.38ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 43.41ms - 44.37ms - faster ✔
7% - 9%
3.22ms - 4.57ms
branch 637 kB 47.31ms - 48.26ms slower ❌
7% - 10%
3.22ms - 4.57ms		 -

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 39.65ms - 40.55ms - faster ✔
3% - 7%
1.45ms - 2.81ms
branch 422 kB 41.72ms - 42.74ms slower ❌
4% - 7%
1.45ms - 2.81ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 102.86ms - 105.91ms - unsure 🔍
-2% - +1%
-2.21ms - +0.91ms
branch 527 kB 104.72ms - 105.34ms unsure 🔍
-1% - +2%
-0.91ms - +2.21ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 61.56ms - 64.86ms - faster ✔
1% - 7%
0.51ms - 4.66ms
branch 519 kB 64.55ms - 67.05ms slower ❌
1% - 7%
0.51ms - 4.66ms		 -
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 165.09ms - 171.55ms - faster ✔
15% - 19%
30.54ms - 39.90ms
branch 408 kB 200.16ms - 206.92ms slower ❌
18% - 24%
30.54ms - 39.90ms		 -

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 112.52ms - 117.84ms - faster ✔
3% - 9%
3.82ms - 11.38ms
branch 478 kB 120.09ms - 125.47ms slower ❌
3% - 10%
3.82ms - 11.38ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 149.15ms - 154.89ms - faster ✔
9% - 13%
14.68ms - 22.24ms
branch 520 kB 168.01ms - 172.95ms slower ❌
9% - 15%
14.68ms - 22.24ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 111.71ms - 117.29ms - faster ✔
3% - 10%
3.64ms - 11.88ms
branch 543 kB 119.23ms - 125.29ms slower ❌
3% - 10%
3.64ms - 11.88ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 278.09ms - 281.07ms - faster ✔
13% - 14%
41.16ms - 46.52ms
branch 661 kB 321.19ms - 325.65ms slower ❌
15% - 17%
41.16ms - 46.52ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 137.94ms - 140.50ms - faster ✔
1% - 3%
1.75ms - 4.77ms
branch 617 kB 141.68ms - 143.28ms slower ❌
1% - 3%
1.75ms - 4.77ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 128.87ms - 130.69ms - faster ✔
6% - 9%
8.39ms - 12.25ms
branch 616 kB 138.40ms - 141.80ms slower ❌
6% - 9%
8.39ms - 12.25ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1884.58ms - 1889.90ms - unsure 🔍
-0% - +0%
-0.98ms - +5.46ms
branch 804 kB 1883.19ms - 1886.81ms unsure 🔍
-0% - +0%
-5.46ms - +0.98ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1893.95ms - 1899.25ms - unsure 🔍
-0% - +0%
-4.07ms - +3.15ms
branch 802 kB 1894.61ms - 1899.51ms unsure 🔍
-0% - +0%
-3.15ms - +4.07ms		 -

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 29.13ms - 31.27ms - unsure 🔍
-6% - +5%
-1.71ms - +1.39ms
branch 416 kB 29.24ms - 31.48ms unsure 🔍
-5% - +6%
-1.39ms - +1.71ms		 -

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 200.69ms - 208.55ms - unsure 🔍
-4% - +2%
-7.32ms - +3.80ms
branch 456 kB 202.45ms - 210.31ms unsure 🔍
-2% - +4%
-3.80ms - +7.32ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 791.31ms - 809.17ms - faster ✔
5% - 8%
46.46ms - 69.94ms
branch 677 kB 850.82ms - 866.06ms slower ❌
6% - 9%
46.46ms - 69.94ms		 -

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 99.78ms - 106.02ms - faster ✔
1% - 8%
1.09ms - 9.15ms
branch 447 kB 105.48ms - 110.56ms slower ❌
1% - 9%
1.09ms - 9.15ms		 -

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 111.98ms - 116.90ms - faster ✔
6% - 11%
7.16ms - 14.04ms
branch 454 kB 122.64ms - 127.44ms slower ❌
6% - 12%
7.16ms - 14.04ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 72.05ms - 77.63ms - unsure 🔍
-5% - +3%
-3.96ms - +2.52ms
branch 494 kB 73.91ms - 77.21ms unsure 🔍
-3% - +5%
-2.52ms - +3.96ms		 -

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 92.57ms - 97.15ms - faster ✔
6% - 12%
6.10ms - 13.02ms
branch 407 kB 101.84ms - 107.00ms slower ❌
6% - 14%
6.10ms - 13.02ms		 -

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 188.64ms - 192.72ms - faster ✔
2% - 5%
4.54ms - 9.78ms
branch 635 kB 196.19ms - 199.49ms slower ❌
2% - 5%
4.54ms - 9.78ms		 -

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 468 kB 187.29ms - 196.99ms - unsure 🔍
-4% - +3%
-6.95ms - +5.07ms
branch 446 kB 189.52ms - 196.64ms unsure 🔍
-3% - +4%
-5.07ms - +6.95ms		 -

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 509 kB 78.48ms - 80.76ms - faster ✔
6% - 10%
4.99ms - 9.13ms
branch 487 kB 84.95ms - 88.41ms slower ❌
6% - 12%
4.99ms - 9.13ms		 -

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 158.55ms - 164.17ms - faster ✔
0% - 5%
0.76ms - 8.52ms
branch 448 kB 163.32ms - 168.68ms slower ❌
0% - 5%
0.76ms - 8.52ms		 -

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 156.19ms - 162.13ms - unsure 🔍
-5% - +0%
-7.84ms - +0.60ms
branch 449 kB 159.79ms - 165.77ms unsure 🔍
-0% - +5%
-0.60ms - +7.84ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 61.24ms - 63.96ms - faster ✔
0% - 6%
0.26ms - 3.86ms
branch 720 kB 63.47ms - 65.85ms slower ❌
0% - 6%
0.26ms - 3.86ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 728.65ms - 739.23ms - slower ❌
1% - 4%
9.21ms - 30.11ms
branch 720 kB 705.27ms - 723.29ms faster ✔
1% - 4%
9.21ms - 30.11ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 106.89ms - 112.11ms - faster ✔
7% - 13%
7.96ms - 16.24ms
branch 646 kB 118.39ms - 124.81ms slower ❌
7% - 15%
7.96ms - 16.24ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 120.16ms - 126.68ms - unsure 🔍
-4% - +3%
-5.38ms - +3.78ms
branch 513 kB 121.01ms - 127.43ms unsure 🔍
-3% - +4%
-3.78ms - +5.38ms		 -

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 104.56ms - 110.52ms - unsure 🔍
-4% - +3%
-4.02ms - +3.74ms
branch 413 kB 105.20ms - 110.16ms unsure 🔍
-3% - +4%
-3.74ms - +4.02ms		 -

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 52.93ms - 57.15ms - unsure 🔍
-6% - +4%
-3.14ms - +2.46ms
branch 383 kB 53.54ms - 57.22ms unsure 🔍
-4% - +6%
-2.46ms - +3.14ms		 -

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 84.87ms - 89.09ms - unsure 🔍
-2% - +6%
-1.95ms - +4.99ms
branch 431 kB 82.70ms - 88.22ms unsure 🔍
-6% - +2%
-4.99ms - +1.95ms		 -

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 20.77ms - 22.11ms - unsure 🔍
-4% - +3%
-0.95ms - +0.75ms
branch 379 kB 21.01ms - 22.07ms unsure 🔍
-4% - +4%
-0.75ms - +0.95ms		 -

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 26.02ms - 28.22ms - faster ✔
7% - 16%
2.24ms - 4.96ms
branch 386 kB 29.92ms - 31.52ms slower ❌
8% - 19%
2.24ms - 4.96ms		 -

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 33.81ms - 35.75ms - faster ✔
4% - 11%
1.29ms - 4.31ms
branch 393 kB 36.42ms - 38.74ms slower ❌
4% - 13%
1.29ms - 4.31ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 431.06ms - 440.94ms - faster ✔
2% - 5%
7.83ms - 24.45ms
branch 472 kB 445.46ms - 458.82ms slower ❌
2% - 6%
7.83ms - 24.45ms		 -

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 83.39ms - 87.81ms - unsure 🔍
-5% - +2%
-4.08ms - +1.48ms
branch 398 kB 85.21ms - 88.59ms unsure 🔍
-2% - +5%
-1.48ms - +4.08ms		 -

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 146.33ms - 152.47ms - faster ✔
11% - 16%
18.96ms - 27.20ms
branch 516 kB 169.72ms - 175.24ms slower ❌
12% - 18%
18.96ms - 27.20ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 819 kB 646.77ms - 660.91ms - slower ❌
3% - 5%
17.26ms - 32.26ms
branch 775 kB 626.59ms - 631.57ms faster ✔
3% - 5%
17.26ms - 32.26ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 48.44ms - 49.16ms - faster ✔
4% - 7%
1.91ms - 3.57ms
branch 779 kB 50.79ms - 52.29ms slower ❌
4% - 7%
1.91ms - 3.57ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 664.70ms - 672.18ms - slower ❌
3% - 5%
21.59ms - 30.37ms
branch 768 kB 640.17ms - 644.75ms faster ✔
3% - 5%
21.59ms - 30.37ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 92.25ms - 98.59ms - unsure 🔍
-5% - +2%
-5.03ms - +1.87ms
branch 564 kB 95.65ms - 98.35ms unsure 🔍
-2% - +5%
-1.87ms - +5.03ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 56.50ms - 60.46ms - faster ✔
7% - 16%
4.36ms - 10.68ms
branch 406 kB 63.54ms - 68.46ms slower ❌
7% - 19%
4.36ms - 10.68ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 1006.19ms - 1031.33ms - faster ✔
4% - 6%
38.05ms - 65.35ms
branch 527 kB 1065.14ms - 1075.78ms slower ❌
4% - 6%
38.05ms - 65.35ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 29.21ms - 32.11ms - unsure 🔍
-9% - +3%
-2.95ms - +0.99ms
branch 374 kB 30.30ms - 32.98ms unsure 🔍
-3% - +10%
-0.99ms - +2.95ms		 -

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 58.41ms - 61.27ms - unsure 🔍
-5% - +1%
-2.99ms - +0.67ms
branch 399 kB 59.85ms - 62.15ms unsure 🔍
-1% - +5%
-0.67ms - +2.99ms		 -

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 73.22ms - 76.30ms - unsure 🔍
-6% - +0%
-4.65ms - +0.13ms
branch 397 kB 75.20ms - 78.84ms unsure 🔍
-0% - +6%
-0.13ms - +4.65ms		 -

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 71.44ms - 75.48ms - faster ✔
8% - 15%
6.24ms - 12.40ms
branch 464 kB 80.46ms - 85.10ms slower ❌
8% - 17%
6.24ms - 12.40ms		 -

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 442 kB 343.96ms - 356.44ms - faster ✔
4% - 8%
14.24ms - 30.72ms
branch 419 kB 367.30ms - 378.06ms slower ❌
4% - 9%
14.24ms - 30.72ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 160.86ms - 165.74ms - faster ✔
1% - 6%
1.75ms - 10.05ms
branch 472 kB 165.84ms - 172.56ms slower ❌
1% - 6%
1.75ms - 10.05ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1873.79ms - 1876.97ms - unsure 🔍
-0% - -0%
-8.01ms - -2.83ms
branch 737 kB 1878.76ms - 1882.84ms unsure 🔍
+0% - +0%
+2.83ms - +8.01ms		 -

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 32.35ms - 34.41ms - faster ✔
4% - 11%
1.23ms - 4.17ms
branch 399 kB 35.02ms - 37.14ms slower ❌
3% - 13%
1.23ms - 4.17ms		 -

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 33.62ms - 35.50ms - faster ✔
2% - 12%
0.79ms - 4.61ms
branch 391 kB 35.60ms - 38.92ms slower ❌
2% - 13%
0.79ms - 4.61ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 271.94ms - 279.78ms - faster ✔
4% - 8%
12.11ms - 23.53ms
branch 498 kB 289.52ms - 297.84ms slower ❌
4% - 9%
12.11ms - 23.53ms		 -

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 198.67ms - 205.77ms - unsure 🔍
-3% - +2%
-6.71ms - +3.67ms
branch 416 kB 199.96ms - 207.52ms unsure 🔍
-2% - +3%
-3.67ms - +6.71ms		 -

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 29.47ms - 31.61ms - unsure 🔍
-7% - +4%
-2.17ms - +1.21ms
branch 442 kB 29.71ms - 32.33ms unsure 🔍
-4% - +7%
-1.21ms - +2.17ms		 -

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 48.13ms - 50.99ms - faster ✔
1% - 9%
0.45ms - 4.63ms
branch 425 kB 50.58ms - 53.62ms slower ❌
1% - 9%
0.45ms - 4.63ms		 -

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 61.85ms - 65.11ms - faster ✔
7% - 14%
5.13ms - 10.07ms
branch 422 kB 69.22ms - 72.94ms slower ❌
8% - 16%
5.13ms - 10.07ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 78.57ms - 82.15ms - slower ❌
6% - 12%
4.81ms - 8.87ms
branch 661 kB 72.56ms - 74.48ms faster ✔
6% - 11%
4.81ms - 8.87ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 47.16ms - 48.40ms - faster ✔
3% - 7%
1.36ms - 3.72ms
branch 539 kB 49.32ms - 51.32ms slower ❌
3% - 8%
1.36ms - 3.72ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 123.62ms - 130.18ms - slower ❌
0% - 7%
0.57ms - 8.07ms
branch 661 kB 120.77ms - 124.39ms faster ✔
1% - 6%
0.57ms - 8.07ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 91.00ms - 94.72ms - faster ✔
5% - 10%
4.71ms - 9.97ms
branch 637 kB 98.35ms - 102.05ms slower ❌
5% - 11%
4.71ms - 9.97ms		 -

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 86.30ms - 91.58ms - faster ✔
2% - 10%
1.80ms - 9.96ms
branch 422 kB 91.71ms - 97.93ms slower ❌
2% - 11%
1.80ms - 9.96ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 167.08ms - 176.52ms - unsure 🔍
-4% - +2%
-7.57ms - +3.97ms
branch 527 kB 170.29ms - 176.91ms unsure 🔍
-2% - +4%
-3.97ms - +7.57ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 103.22ms - 108.18ms - unsure 🔍
-6% - +0%
-7.05ms - +0.29ms
branch 519 kB 106.37ms - 111.79ms unsure 🔍
-0% - +7%
-0.29ms - +7.05ms		 -

@rubencarvalho rubencarvalho marked this pull request as ready for review September 26, 2024 08:14
@rubencarvalho rubencarvalho requested a review from a team as a code owner September 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajdeepc Rajdeepc Awaiting requested review from Rajdeepc

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubencarvalho @coveralls @Rajdeepc