Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(button): add missing reactive-controller dependency #4958

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

TarunAdobe
Copy link
Contributor

Description

add missing reactive-controller dependency.

Related issue(s)

  • Missing dependency error.

Motivation and context

Missing dependency error.

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@TarunAdobe TarunAdobe requested a review from a team as a code owner November 26, 2024 10:21
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 2298f9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Nov 26, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.04 kB 236.51 kB 🏆 236.83 kB
Scripts 61.183 kB 54.102 kB 🏆 54.32 kB
Stylesheet 53.898 kB 47.868 kB 🏆 47.994 kB
Document 6.223 kB 5.46 kB 🏆 5.462 kB
Font 126.874 kB 126.667 kB 126.64 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12028738568

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.188%

Totals Coverage Status
Change from base Build 12026399693: -0.003%
Covered Lines: 32397
Relevant Lines: 32817

💛 - Coveralls

Copy link

github-actions bot commented Nov 26, 2024

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 54.42ms - 55.36ms - faster ✔
4% - 6%
2.14ms - 3.58ms
branch 715 kB 57.20ms - 58.29ms slower ❌
4% - 7%
2.14ms - 3.58ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 78.69ms - 80.04ms - faster ✔
3% - 5%
2.45ms - 4.38ms
branch 770 kB 82.08ms - 83.47ms slower ❌
3% - 6%
2.45ms - 4.38ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 50.38ms - 52.84ms - faster ✔
4% - 10%
2.03ms - 5.56ms
branch 793 kB 54.14ms - 56.68ms slower ❌
4% - 11%
2.03ms - 5.56ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 143.34ms - 145.99ms - faster ✔
3% - 5%
3.74ms - 7.48ms
branch 916 kB 148.95ms - 151.60ms slower ❌
3% - 5%
3.74ms - 7.48ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 70.67ms - 71.76ms - faster ✔
6% - 8%
4.34ms - 6.11ms
branch 874 kB 75.73ms - 77.14ms slower ❌
6% - 9%
4.34ms - 6.11ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 69.96ms - 70.96ms - faster ✔
5% - 7%
3.51ms - 5.35ms
branch 873 kB 74.11ms - 75.66ms slower ❌
5% - 8%
3.51ms - 5.35ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1874.81ms - 1877.83ms - unsure 🔍
-0% - +0%
-2.07ms - +1.85ms
branch 1.05 MB 1875.19ms - 1877.68ms unsure 🔍
-0% - +0%
-1.85ms - +2.07ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1878.35ms - 1881.45ms - unsure 🔍
-0% - -0%
-4.48ms - -0.03ms
branch 1.05 MB 1880.56ms - 1883.75ms unsure 🔍
+0% - +0%
+0.03ms - +4.48ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 688 kB 14.24ms - 14.53ms - faster ✔
1% - 4%
0.15ms - 0.54ms
branch 664 kB 14.59ms - 14.86ms slower ❌
1% - 4%
0.15ms - 0.54ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 108.71ms - 111.58ms - faster ✔
0% - 3%
0.04ms - 3.09ms
branch 696 kB 111.19ms - 112.23ms slower ❌
0% - 3%
0.04ms - 3.09ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 978 kB 522.56ms - 529.98ms - faster ✔
2% - 3%
8.17ms - 17.76ms
branch 935 kB 536.19ms - 542.28ms slower ❌
2% - 3%
8.17ms - 17.76ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 45.38ms - 46.37ms - faster ✔
6% - 8%
2.84ms - 4.18ms
branch 688 kB 48.93ms - 49.83ms slower ❌
6% - 9%
2.84ms - 4.18ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 51.58ms - 52.40ms - faster ✔
6% - 9%
3.23ms - 5.07ms
branch 696 kB 55.32ms - 56.96ms slower ❌
6% - 10%
3.23ms - 5.07ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 92.63ms - 94.49ms - faster ✔
5% - 7%
4.60ms - 7.15ms
branch 864 kB 98.57ms - 100.30ms slower ❌
5% - 8%
4.60ms - 7.15ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 42.69ms - 43.72ms - faster ✔
0% - 3%
0.16ms - 1.32ms
branch 957 kB 43.69ms - 44.20ms slower ❌
0% - 3%
0.16ms - 1.32ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 401.05ms - 406.23ms - faster ✔
1% - 3%
3.89ms - 12.12ms
branch 957 kB 408.45ms - 414.84ms slower ❌
1% - 3%
3.89ms - 12.12ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 53.86ms - 54.74ms - faster ✔
7% - 9%
3.91ms - 5.39ms
branch 898 kB 58.36ms - 59.54ms slower ❌
7% - 10%
3.91ms - 5.39ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 81.78ms - 82.70ms - faster ✔
0% - 2%
0.36ms - 2.02ms
branch 759 kB 82.74ms - 84.12ms slower ❌
0% - 2%
0.36ms - 2.02ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 16.94ms - 17.24ms - faster ✔
7% - 10%
1.24ms - 1.81ms
branch 636 kB 18.38ms - 18.86ms slower ❌
7% - 11%
1.24ms - 1.81ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 213.45ms - 216.25ms - faster ✔
2% - 4%
4.95ms - 8.46ms
branch 716 kB 220.48ms - 222.62ms slower ❌
2% - 4%
4.95ms - 8.46ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 794 kB 74.35ms - 75.55ms - faster ✔
10% - 12%
8.03ms - 10.08ms
branch 770 kB 83.17ms - 84.84ms slower ❌
11% - 14%
8.03ms - 10.08ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 431.15ms - 434.15ms - faster ✔
1% - 2%
2.78ms - 6.80ms
branch 939 kB 436.09ms - 438.78ms slower ❌
1% - 2%
2.78ms - 6.80ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 26.41ms - 26.98ms - faster ✔
4% - 7%
1.08ms - 1.84ms
branch 1.02 MB 27.90ms - 28.41ms slower ❌
4% - 7%
1.08ms - 1.84ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 353.79ms - 357.77ms - faster ✔
2% - 4%
7.40ms - 13.02ms
branch 1.01 MB 364.01ms - 367.97ms slower ❌
2% - 4%
7.40ms - 13.02ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 44.52ms - 45.36ms - faster ✔
5% - 8%
2.60ms - 3.86ms
branch 805 kB 47.71ms - 48.64ms slower ❌
6% - 9%
2.60ms - 3.86ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 30.31ms - 30.74ms - faster ✔
4% - 7%
1.37ms - 2.15ms
branch 650 kB 31.96ms - 32.61ms slower ❌
4% - 7%
1.37ms - 2.15ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 512.67ms - 519.43ms - faster ✔
3% - 5%
18.77ms - 28.80ms
branch 774 kB 536.14ms - 543.53ms slower ❌
4% - 6%
18.77ms - 28.80ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 108.60ms - 109.60ms - faster ✔
1% - 2%
1.21ms - 2.52ms
branch 774 kB 110.55ms - 111.39ms slower ❌
1% - 2%
1.21ms - 2.52ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 43.95ms - 44.70ms - faster ✔
4% - 6%
1.72ms - 2.93ms
branch 713 kB 46.18ms - 47.12ms slower ❌
4% - 7%
1.72ms - 2.93ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 79.40ms - 80.93ms - faster ✔
4% - 6%
3.01ms - 4.96ms
branch 717 kB 83.55ms - 84.75ms slower ❌
4% - 6%
3.01ms - 4.96ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 15.00ms - 15.22ms - unsure 🔍
-1% - +2%
-0.08ms - +0.24ms
branch 688 kB 14.91ms - 15.15ms unsure 🔍
-2% - +1%
-0.24ms - +0.08ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 697 kB 31.41ms - 31.94ms - faster ✔
7% - 10%
2.55ms - 3.47ms
branch 672 kB 34.31ms - 35.06ms slower ❌
8% - 11%
2.55ms - 3.47ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 870 kB 36.05ms - 36.60ms - faster ✔
4% - 6%
1.41ms - 2.24ms
branch 805 kB 37.83ms - 38.46ms slower ❌
4% - 6%
1.41ms - 2.24ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.54ms - 26.06ms - faster ✔
8% - 10%
2.13ms - 2.91ms
branch 788 kB 28.03ms - 28.61ms slower ❌
8% - 11%
2.13ms - 2.91ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 53.69ms - 55.05ms - faster ✔
5% - 7%
2.59ms - 4.29ms
branch 910 kB 57.31ms - 58.33ms slower ❌
5% - 8%
2.59ms - 4.29ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 44.28ms - 45.29ms - faster ✔
6% - 9%
2.79ms - 4.29ms
branch 886 kB 47.77ms - 48.88ms slower ❌
6% - 10%
2.79ms - 4.29ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 63.73ms - 64.95ms - faster ✔
3% - 6%
2.09ms - 3.92ms
branch 761 kB 66.66ms - 68.03ms slower ❌
3% - 6%
2.09ms - 3.92ms
-
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 120.66ms - 127.90ms - faster ✔
1% - 9%
1.63ms - 12.09ms
branch 715 kB 127.37ms - 134.91ms slower ❌
1% - 10%
1.63ms - 12.09ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 164.96ms - 174.60ms - faster ✔
0% - 7%
0.48ms - 12.96ms
branch 770 kB 172.53ms - 180.47ms slower ❌
0% - 8%
0.48ms - 12.96ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 115.86ms - 125.46ms - unsure 🔍
-9% - +3%
-10.80ms - +3.28ms
branch 793 kB 119.27ms - 129.57ms unsure 🔍
-3% - +9%
-3.28ms - +10.80ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 285.99ms - 289.61ms - faster ✔
14% - 16%
47.00ms - 53.48ms
branch 916 kB 335.36ms - 340.72ms slower ❌
16% - 19%
47.00ms - 53.48ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 153.69ms - 157.47ms - slower ❌
6% - 9%
9.23ms - 13.25ms
branch 874 kB 143.66ms - 145.02ms faster ✔
6% - 8%
9.23ms - 13.25ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 135.96ms - 138.64ms - faster ✔
4% - 7%
5.10ms - 10.50ms
branch 873 kB 142.76ms - 147.44ms slower ❌
4% - 8%
5.10ms - 10.50ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1891.20ms - 1902.40ms - unsure 🔍
-1% - +0%
-9.69ms - +2.69ms
branch 1.05 MB 1897.67ms - 1902.93ms unsure 🔍
-0% - +1%
-2.69ms - +9.69ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1900.90ms - 1906.22ms - unsure 🔍
-0% - +0%
-1.58ms - +4.82ms
branch 1.05 MB 1900.17ms - 1903.71ms unsure 🔍
-0% - +0%
-4.82ms - +1.58ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 688 kB 29.80ms - 32.72ms - unsure 🔍
-8% - +5%
-2.54ms - +1.54ms
branch 664 kB 30.33ms - 33.19ms unsure 🔍
-5% - +8%
-1.54ms - +2.54ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 206.25ms - 216.55ms - unsure 🔍
-2% - +5%
-3.35ms - +11.15ms
branch 696 kB 202.40ms - 212.60ms unsure 🔍
-5% - +2%
-11.15ms - +3.35ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 978 kB 830.40ms - 860.20ms - unsure 🔍
-4% - +0%
-31.83ms - +0.87ms
branch 935 kB 854.05ms - 867.51ms unsure 🔍
-0% - +4%
-0.87ms - +31.83ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 104.54ms - 112.14ms - unsure 🔍
-9% - +0%
-10.28ms - +0.48ms
branch 688 kB 109.43ms - 117.05ms unsure 🔍
-1% - +10%
-0.48ms - +10.28ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 122.23ms - 129.01ms - faster ✔
3% - 11%
3.76ms - 14.68ms
branch 696 kB 130.56ms - 139.12ms slower ❌
3% - 12%
3.76ms - 14.68ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 197.46ms - 203.34ms - faster ✔
4% - 8%
7.95ms - 16.89ms
branch 864 kB 209.46ms - 216.18ms slower ❌
4% - 8%
7.95ms - 16.89ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 72.25ms - 78.63ms - unsure 🔍
-1% - +8%
-1.05ms - +5.53ms
branch 957 kB 72.39ms - 74.01ms unsure 🔍
-7% - +1%
-5.53ms - +1.05ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 735.52ms - 750.56ms - slower ❌
2% - 7%
16.72ms - 48.68ms
branch 957 kB 696.24ms - 724.44ms faster ✔
2% - 7%
16.72ms - 48.68ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 114.08ms - 120.00ms - unsure 🔍
-5% - +1%
-6.19ms - +1.67ms
branch 898 kB 116.71ms - 121.89ms unsure 🔍
-1% - +5%
-1.67ms - +6.19ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 129.40ms - 137.00ms - unsure 🔍
-2% - +6%
-2.29ms - +7.57ms
branch 759 kB 127.42ms - 133.70ms unsure 🔍
-6% - +2%
-7.57ms - +2.29ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 43.29ms - 46.23ms - unsure 🔍
-9% - +2%
-4.43ms - +1.07ms
branch 636 kB 44.12ms - 48.76ms unsure 🔍
-2% - +10%
-1.07ms - +4.43ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 399.83ms - 415.49ms - faster ✔
0% - 6%
0.65ms - 23.59ms
branch 716 kB 411.40ms - 428.16ms slower ❌
0% - 6%
0.65ms - 23.59ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 794 kB 155.19ms - 162.25ms - faster ✔
6% - 12%
10.25ms - 20.83ms
branch 770 kB 170.32ms - 178.20ms slower ❌
6% - 13%
10.25ms - 20.83ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 664.82ms - 687.02ms - slower ❌
6% - 9%
35.62ms - 58.74ms
branch 1.01 MB 625.52ms - 631.96ms faster ✔
5% - 9%
35.62ms - 58.74ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 51.66ms - 52.38ms - faster ✔
3% - 5%
1.40ms - 2.48ms
branch 1.02 MB 53.56ms - 54.36ms slower ❌
3% - 5%
1.40ms - 2.48ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 678.78ms - 686.46ms - slower ❌
8% - 9%
47.44ms - 56.52ms
branch 1.01 MB 628.22ms - 633.06ms faster ✔
7% - 8%
47.44ms - 56.52ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 98.79ms - 110.17ms - slower ❌
1% - 13%
0.57ms - 12.27ms
branch 805 kB 96.71ms - 99.41ms faster ✔
1% - 11%
0.57ms - 12.27ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 64.23ms - 69.81ms - unsure 🔍
-9% - +2%
-6.22ms - +1.34ms
branch 650 kB 66.92ms - 72.00ms unsure 🔍
-2% - +9%
-1.34ms - +6.22ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 989.95ms - 997.61ms - faster ✔
4% - 8%
46.49ms - 81.71ms
branch 774 kB 1040.69ms - 1075.07ms slower ❌
5% - 8%
46.49ms - 81.71ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 147.42ms - 157.10ms - unsure 🔍
-8% - -0%
-13.35ms - +0.07ms
branch 774 kB 154.25ms - 163.55ms unsure 🔍
-0% - +9%
-0.07ms - +13.35ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 89.28ms - 95.40ms - unsure 🔍
-9% - +1%
-8.30ms - +0.62ms
branch 713 kB 92.93ms - 99.43ms unsure 🔍
-1% - +9%
-0.62ms - +8.30ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 163.12ms - 174.20ms - unsure 🔍
-6% - +2%
-10.32ms - +3.80ms
branch 717 kB 167.54ms - 176.30ms unsure 🔍
-2% - +6%
-3.80ms - +10.32ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 33.10ms - 37.02ms - unsure 🔍
-6% - +10%
-2.05ms - +3.45ms
branch 688 kB 32.42ms - 36.30ms unsure 🔍
-10% - +6%
-3.45ms - +2.05ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 697 kB 72.39ms - 78.13ms - faster ✔
2% - 12%
1.24ms - 10.04ms
branch 672 kB 77.57ms - 84.23ms slower ❌
1% - 14%
1.24ms - 10.04ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 87.90ms - 94.22ms - slower ❌
13% - 23%
10.17ms - 17.55ms
branch 910 kB 75.29ms - 79.11ms faster ✔
12% - 19%
10.17ms - 17.55ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 50.66ms - 52.58ms - faster ✔
2% - 7%
1.00ms - 3.60ms
branch 788 kB 53.04ms - 54.80ms slower ❌
2% - 7%
1.00ms - 3.60ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 148.29ms - 153.51ms - slower ❌
13% - 19%
17.24ms - 24.12ms
branch 910 kB 127.99ms - 132.45ms faster ✔
12% - 16%
17.24ms - 24.12ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 88.02ms - 90.82ms - faster ✔
26% - 32%
31.23ms - 42.41ms
branch 886 kB 120.83ms - 131.65ms slower ❌
35% - 48%
31.23ms - 42.41ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 111.90ms - 119.34ms - unsure 🔍
-8% - +1%
-9.95ms - +1.83ms
branch 761 kB 115.11ms - 124.25ms unsure 🔍
-2% - +9%
-1.83ms - +9.95ms
-

@Rajdeepc Rajdeepc merged commit ce61b60 into main Nov 26, 2024
27 checks passed
@Rajdeepc Rajdeepc deleted the ttomar/button-dependencies branch November 26, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants