Skip to content

style(tabs): added sp-tabs-overflow mod tokens #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+15 −5
Closed

style(tabs): added sp-tabs-overflow mod tokens #5386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41afd7a
style(tabs): added overflow mod tokens
mizgaionutalexandru Apr 22, 2025
5e577c6
chore: changeset
mizgaionutalexandru Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-seals-sniff.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spectrum-web-components/tabs': patch
---

feat(tabs): add customization tokens for overflow button positioning and shadow
15 changes: 10 additions & 5 deletions packages/tabs/src/tabs-overflow.css
View file
Original file line number Diff line number Diff line change
@@ -14,19 +14,24 @@ governing permissions and limitations under the License.
inset: 0;
width: 100%;

--sp-tabs-overflow-next-button-right: calc(
-1 * var(--spectrum-component-edge-to-text-100)
--sp-tabs-overflow-next-button-right: var(
--mod-sp-tabs-overflow-next-button-right,
calc(-1 * var(--spectrum-component-edge-to-text-100))
);
--sp-tabs-overflow-previous-button-left: calc(
-1 * var(--spectrum-component-edge-to-text-100)
--sp-tabs-overflow-previous-button-left: var(
--mod-sp-tabs-overflow-previous-button-left,
calc(-1 * var(--spectrum-component-edge-to-text-100))
);
--sp-tabs-overflow-button-height: calc(
var(--spectrum-tab-item-height-medium) -
var(--spectrum-border-width-200)
);
--sp-tabs-overflow-button-size: var(--spectrum-tab-item-height-medium);
--sp-tabs-overflow-icon-color: var(--spectrum-gray-800);
--sp-tabs-overflow-shadow-color: var(--spectrum-gray-100);
--sp-tabs-overflow-shadow-color: var(
--mod-sp-tabs-overflow-shadow-color,
var(--spectrum-gray-100)
);
Comment on lines +17 to +34
Copy link
Contributor

@Rajdeepc Rajdeepc Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary fix and is against the mod inheritance property contract. Please reach out to the channel for better support from the spectrum-css team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is not in spectrum-css as far as I'm aware. Shouldn't we add these --mod tokens here?

--sp-tabs-overflow-shadow-width: 50px;
--mod-actionbutton-icon-size: var(--spectrum-workflow-icon-size-100);
}