Skip to content

chore: test circleci's max auto-reruns feature #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: test circleci's max auto-reruns feature #5755

wants to merge 1 commit into from

Conversation

castastrophe
Copy link
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 00131ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the castastrophe/chore-test-max-auto-reruns branch from 46bd1e4 to dadc333 Compare September 25, 2025 17:00
@castastrophe castastrophe self-assigned this Sep 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5755

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@github-actions GitHub Actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the castastrophe/chore-test-max-auto-reruns branch 2 times, most recently from a69aad5 to bd4aa74 Compare September 25, 2025 22:34
@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18102662587

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.919%
Totals Coverage Status
Change from base Build 18022665045: 0.003%
Covered Lines: 34050
Relevant Lines: 34574
💛 - Coveralls

@castastrophe castastrophe force-pushed the castastrophe/chore-test-max-auto-reruns branch from bd4aa74 to 3e271a8 Compare September 25, 2025 22:46
@cdransf @castastrophe
docs(table): update a11y docs (#5739)
00131ad 
* docs(table): update a11y docs

* chore(docs): address feedback

* Update packages/table/README.md

Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>

---------

Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
@castastrophe castastrophe force-pushed the castastrophe/chore-test-max-auto-reruns branch from 3e271a8 to 00131ad Compare September 29, 2025 15:43
castastrophe
castastrophe commented Sep 30, 2025
View reviewed changes
.circleci/config.yml
command: |
TEST=$(circleci tests glob "{packages,tools}/*/test/*.test.js" | grep -v ".*-memory\.test\.js$" | circleci tests split --split-by=timings)
yarn test:start --files $TEST --config web-test-runner.config.ci-chromium.js --group unit-ci
max_auto_reruns: 3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnjosh I tested out adding this to our test commands and I'm not seeing any issues in CI. What would you think of adding to as a ticket in our backlog? It still reports that tests had to be rerun and it still flags specific tests that fail as flaky so it doesn't mask any underlying issues; just saves PRs from having to manually re-run when they're not making changes to the flaky files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@castastrophe castastrophe

Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@castastrophe @coveralls @cdransf