fix(overlay-trigger): update overlay-trigger interactions type #5806
+164
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85aaf9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsChromeoverlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
Firefoxoverlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
|
Pull Request Test Coverage Report for Build 18740821736Details
💛 - Coveralls |
rubencarvalho
commented
Oct 15, 2025
| this.innerTrigger = this.testDiv.querySelector( | ||
| '#inner-trigger' | ||
| ) as OverlayTrigger; | ||
| )! as OverlayTrigger; |
There was a problem hiding this comment.
By casting these, it will offer us correct Intellisense.
rubencarvalho
commented
Oct 15, 2025
| 'inline' | 'modal' | 'replace' | ||
| >; | ||
| await elementUpdated(this.outerTrigger); | ||
| const outerTrigger = this.outerTrigger as OverlayTrigger; |
There was a problem hiding this comment.
Casting this means that if we ever pass a type that’s not valid, the next line will throw TS error and test will fail.
rubencarvalho
added
Component: Overlay
Status: Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the type property in
OverlayTriggerclass to acceptOverlayTypesinstead of the more restrictiveOverlayTriggerInteractions. This change expands the allowed values from 'modal' to all overlay types ('auto', 'hint', 'manual', 'modal', 'page') for the click content. Also updated the documentation to reflect this.What I changed:
OverlayTriggerInteractionstoTriggerInteractionsOVERLAY_TYPESconst array for runtime use and to have a single source of truth, also to use in the...Motivation and context
The previous definition was incorrect.
Related issue(s)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases