-
Notifications
You must be signed in to change notification settings - Fork 236
docs(grid): enhance README with detailed usage, options, and accessib… #5810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ility information
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 18681605860Details
💛 - Coveralls |
nikkimk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
rubencarvalho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left just 1 non-blocking comment
| </script> | ||
| ``` | ||
|
|
||
| <!-- @todo make the example work for a keyboard Tracking in 5582--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to your changes, but do you know if this @todo is still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after merging this PR we can get rid of this Todo
…ility information (adobe#5810)
Overview
This PR reorganizes the grid README.md to follow the established documentation standards structure, improving accessibility and consistency with other components.
Changes Made
Structure Reorganization
bash,javascript)renderItemitemsproperty with array examplesrenderItemmethod with detailed explanationitemSizeproperty with object configurationgapproperty for spacing controlfocusableSelectorproperty for keyboard navigation<kbd>tagsContent Improvements
lit-virtualizeritems,renderItem,itemSize,gap,focusableSelector)Accessibility Enhancements
<kbd>tags for keyboard actionsTesting
Related Documentation
Documentation Standards Compliance
This reorganization ensures the grid documentation:
<kbd>tags to semantically indicate keyboard inputThis reorganization makes the grid documentation more accessible, easier to navigate, and consistent with the established documentation standards across the Spectrum Web Components library.