Skip to content

fix(status-light): add missing accent and cyan variants #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

fix(status-light): add missing accent and cyan variants #5813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c4ec9
feat(statuslight): add missing first-gen variants
marissahuysentruyt Oct 13, 2025
473585a
chore: update golden hash
marissahuysentruyt Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-pans-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spectrum-web-components/status-light': patch
---

**Fixed**: Added missing `accent` and `cyan` variant to status light.
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ parameters:
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: 1bd7e9973de8f318233aa41b5b8a97a2956cd44d
default: 13c4ec984fd6880ccc8dde9dd23f22d6b4337969
wireit_cache_name:
type: string
default: wireit
Expand Down
9 changes: 3 additions & 6 deletions packages/status-light/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,11 @@ Status lights come in various semantic and non-semantic variants to convey diffe
<sp-tab-panel value="semantic">

```html
<sp-status-light variant="neutral">
use for default state
</sp-status-light>
<sp-status-light variant="neutral">use for default state</sp-status-light>
<sp-status-light variant="positive">
use for success or approval
</sp-status-light>
<sp-status-light variant="negative">
use for error or rejection
</sp-status-light>
<sp-status-light variant="negative">use for error or rejection</sp-status-light>
<sp-status-light variant="notice">
use for warning or attention needed
</sp-status-light>
Expand All @@ -110,6 +106,7 @@ Status lights come in various semantic and non-semantic variants to convey diffe
<sp-status-light variant="magenta">magenta status</sp-status-light>
<sp-status-light variant="celery">celery status</sp-status-light>
<sp-status-light variant="purple">purple status</sp-status-light>
<sp-status-light variant="cyan">cyan status</sp-status-light>
Copy link
Collaborator Author

@marissahuysentruyt marissahuysentruyt Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we think about the accent variant?

I haven't added it to the documentation because we don't actually have any design guidance (at least recent guidance I'm aware of) for it. However, CSS had selectors for it, has an accent status light on main right now, and there was an SWC selector for it (which you'll see I had to correct).

```

</sp-tab-panel>
Expand Down
4 changes: 3 additions & 1 deletion packages/status-light/src/StatusLight.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export class StatusLight extends SizedMixin(SpectrumElement, {
*/
@property({ reflect: true })
public variant:
| 'accent'
| 'negative'
| 'notice'
| 'positive'
Expand All @@ -56,7 +57,8 @@ export class StatusLight extends SizedMixin(SpectrumElement, {
| 'chartreuse'
| 'magenta'
| 'celery'
| 'purple' = 'info';
| 'purple'
| 'cyan' = 'info';

protected override render(): TemplateResult {
return html`
Expand Down
7 changes: 5 additions & 2 deletions packages/status-light/src/spectrum-status-light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
--spectrum-statuslight-nonsemantic-purple-color: var(--spectrum-purple-visual-color);
--spectrum-statuslight-nonsemantic-fuchsia-color: var(--spectrum-fuchsia-visual-color);
--spectrum-statuslight-nonsemantic-magenta-color: var(--spectrum-magenta-visual-color);

min-block-size: var(--mod-statuslight-height, var(--spectrum-statuslight-height));
box-sizing: border-box;
font-size: var(--mod-statuslight-font-size, var(--spectrum-statuslight-font-size));
Expand All @@ -102,6 +103,7 @@

:host:before {
--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));

content: "";
inline-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
block-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
Expand All @@ -122,7 +124,7 @@
background-color: var(--mod-statuslight-semantic-neutral-color, var(--spectrum-statuslight-semantic-neutral-color));
}

.spectrum-StatusLight--accent:before {
:host([variant="accent"]):before {
background-color: var(--mod-statuslight-semantic-accent-color, var(--spectrum-statuslight-semantic-accent-color));
}

Expand Down Expand Up @@ -174,7 +176,7 @@
background-color: var(--mod-statuslight-nonsemantic-seafoam-color, var(--spectrum-statuslight-nonsemantic-seafoam-color));
}

.spectrum-StatusLight--cyan:before {
:host([variant="cyan"]):before {
background-color: var(--mod-statuslight-nonsemantic-cyan-color, var(--spectrum-statuslight-nonsemantic-cyan-color));
}

Expand Down Expand Up @@ -202,6 +204,7 @@
:host([dir]) {
--highcontrast-statuslight-content-color-default: CanvasText;
--highcontrast-statuslight-subdued-content-color-default: CanvasText;

forced-color-adjust: none;
}

Expand Down
8 changes: 8 additions & 0 deletions packages/status-light/stories/status-light.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default {
};

export const s = (): TemplateResult => html`
<sp-status-light size="s" variant="accent">accent</sp-status-light>
<sp-status-light size="s" variant="positive">positive</sp-status-light>
<sp-status-light size="s" variant="negative">negative</sp-status-light>
<sp-status-light size="s" variant="notice">notice</sp-status-light>
Expand All @@ -32,9 +33,11 @@ export const s = (): TemplateResult => html`
<sp-status-light size="s" variant="magenta">magenta</sp-status-light>
<sp-status-light size="s" variant="celery">celery</sp-status-light>
<sp-status-light size="s" variant="purple">purple</sp-status-light>
<sp-status-light size="s" variant="cyan">cyan</sp-status-light>
`;

export const m = (): TemplateResult => html`
<sp-status-light size="m" variant="accent">accent</sp-status-light>
<sp-status-light size="m" variant="positive">positive</sp-status-light>
<sp-status-light size="m" variant="negative">negative</sp-status-light>
<sp-status-light size="m" variant="notice">notice</sp-status-light>
Expand All @@ -48,9 +51,11 @@ export const m = (): TemplateResult => html`
<sp-status-light size="m" variant="magenta">magenta</sp-status-light>
<sp-status-light size="m" variant="celery">celery</sp-status-light>
<sp-status-light size="m" variant="purple">purple</sp-status-light>
<sp-status-light size="m" variant="cyan">cyan</sp-status-light>
`;

export const l = (): TemplateResult => html`
<sp-status-light size="l" variant="accent">accent</sp-status-light>
<sp-status-light size="l" variant="positive">positive</sp-status-light>
<sp-status-light size="l" variant="negative">negative</sp-status-light>
<sp-status-light size="l" variant="notice">notice</sp-status-light>
Expand All @@ -64,9 +69,11 @@ export const l = (): TemplateResult => html`
<sp-status-light size="l" variant="magenta">magenta</sp-status-light>
<sp-status-light size="l" variant="celery">celery</sp-status-light>
<sp-status-light size="l" variant="purple">purple</sp-status-light>
<sp-status-light size="l" variant="cyan">cyan</sp-status-light>
`;

export const XL = (): TemplateResult => html`
<sp-status-light size="xl" variant="accent">accent</sp-status-light>
<sp-status-light size="xl" variant="positive">positive</sp-status-light>
<sp-status-light size="xl" variant="negative">negative</sp-status-light>
<sp-status-light size="xl" variant="notice">notice</sp-status-light>
Expand All @@ -80,6 +87,7 @@ export const XL = (): TemplateResult => html`
<sp-status-light size="xl" variant="magenta">magenta</sp-status-light>
<sp-status-light size="xl" variant="celery">celery</sp-status-light>
<sp-status-light size="xl" variant="purple">purple</sp-status-light>
<sp-status-light size="xl" variant="cyan">cyan</sp-status-light>
`;

export const disabledTrue = (): TemplateResult => html`
Expand Down
Loading