Skip to content

Conversation

@shipg22
Copy link

@shipg22 shipg22 commented Oct 21, 2025

Description

https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/menu-submenu--submenu

Submenu interaction is fixed for touch devices.

Submenu should open on hover for desktop and on click for touch devices.
First click should open, and second click should close the submenu on touch devices.

Motivation and context

Related issue(s)

[CCEX-244009]

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/menu-submenu--submenu

First click should open, and second click should close the submenu on touch devices.

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@shipg22 shipg22 requested a review from a team as a code owner October 21, 2025 22:36
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: 5053912

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18848854066

Details

  • 30 of 46 (65.22%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 97.964%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/menu/src/MenuItem.ts 30 46 65.22%
Files with Coverage Reduction New Missed Lines %
packages/menu/src/MenuItem.ts 1 94.13%
Totals Coverage Status
Change from base Build 18844771637: -0.002%
Covered Lines: 34253
Relevant Lines: 34782

💛 - Coveralls

@shipg22 shipg22 force-pushed the shiprag/fix-touch-submenu-interactions branch from 5d2c58a to 8b7aa06 Compare October 22, 2025 17:14
@Rajdeepc
Copy link
Contributor

Rajdeepc commented Oct 23, 2025

Hi @shipg22 Good start! Can you create a couple of manual test cases on the PR description for other reviewers to test this change in various devices and do some sanity check for any regressions.

@Rajdeepc Rajdeepc added Status: WIP PR is a work in progress or draft Contribution labels Oct 23, 2025
@shipg22 shipg22 closed this Oct 23, 2025
@shipg22 shipg22 reopened this Oct 23, 2025
@shipg22 shipg22 closed this Oct 23, 2025
@shipg22 shipg22 reopened this Oct 23, 2025
@shipg22 shipg22 closed this Oct 24, 2025
@shipg22 shipg22 reopened this Oct 24, 2025
@shipg22 shipg22 closed this Oct 24, 2025
@shipg22 shipg22 reopened this Oct 24, 2025
@shipg22
Copy link
Author

shipg22 commented Oct 24, 2025

Hi @shipg22 Good start! Can you create a couple of manual test cases on the PR description for other reviewers to test this change in various devices and do some sanity check for any regressions.

Done, thanks!

@shipg22 shipg22 closed this Oct 27, 2025
@shipg22 shipg22 reopened this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution Status: WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants