-
Notifications
You must be signed in to change notification settings - Fork 235
chore(deps): pin package dependencies in 2nd-gen #5820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: barebones
Are you sure you want to change the base?
Conversation
|
| "@wc-toolkit/storybook-helpers": "9.0.1", | ||
| "autoprefixer": "10.4.21", | ||
| "glob": "11.0.3", | ||
| "playwright": "1.53.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is resolving to the version needed in first-gen… I’m ok with keeping parity for now but wanted to flag this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I think keeping parity is good for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But FYI, we already had
"resolutions": {
"playwright": "1.53.1"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting the following error when I run yarn test:
packages/tray/test/tray.test.js:
🚧 Browser logs on Firefox:
TypeError: error loading dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=OTMOYXsP3zhX9Dy9vkId2
🚧 Browser logs on Chromium:
TypeError: Failed to fetch dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=cMkGLxeferi-7tozR5SB2
🚧 Browser logs on Webkit:
TypeError: Importing a module script failed.
❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.
| "react-dom": "19.1.1", | ||
| "rimraf": "6.0.1", | ||
| "storybook": "9.1.10", | ||
| "typescript": "5.9.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs a full TS build to check for regression. Laying this out here for other reviewers
| "@types/react": "19.1.16", | ||
| "@types/react-dom": "19.1.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason behind bumping "@types/react": "19.1.16" and not to 19.1.1? Shouldn't be a problem though if the ts build passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not reproduce this! Please make sure you run cd second-gen/packages/core && yarn buildand then from yarn test(this command orchestration is fixed on #5791) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with rajdeeps call out for a fresh build with typescript

Description
This change pins package dependencies across the second-gen packages to ensure consistent and reproducible builds.
Note: pinned versions may be minor or patch versions larger than the original. This is because our lockfile was consuming higher versions than we had listed due to our caret approach. I've gone through and tried to map the updated versions to the original lockfile as much as possible.
Motivation and context
Pinning dependencies is essential for:
Related issue(s)
Screenshots (if appropriate)
N/A - This is a dependency management change without visual changes.
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
All packages build successfully with pinned dependencies
yarn installto install pinned dependenciesBuild system works with pinned dependencies
yarn buildTests pass with pinned dependencies
yarn test