Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Oct 22, 2025

Description

This change pins package dependencies across the second-gen packages to ensure consistent and reproducible builds.

Note: pinned versions may be minor or patch versions larger than the original. This is because our lockfile was consuming higher versions than we had listed due to our caret approach. I've gone through and tried to map the updated versions to the original lockfile as much as possible.

Motivation and context

Pinning dependencies is essential for:

  • Ensuring reproducible builds across different environments
  • Preventing unexpected breaking changes from dependency updates
  • Maintaining consistent behavior across all packages in the monorepo
  • Improving security by controlling exactly which versions are used
  • Facilitating easier debugging when issues arise

Related issue(s)

  • contributes to [SWC-1243]

Screenshots (if appropriate)

N/A - This is a dependency management change without visual changes.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • All packages build successfully with pinned dependencies

    1. Go to root directory
    2. Run yarn install to install pinned dependencies
    3. Expect all packages to install without conflicts
  • Build system works with pinned dependencies

    1. Run yarn build
    2. Verify all packages build successfully
    3. Expect no build errors related to dependency conflicts
  • Tests pass with pinned dependencies

    1. Run yarn test
    2. Verify all tests pass
    3. Expect no test failures related to dependency changes

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 2d2cfd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho rubencarvalho changed the base branch from main to barebones October 22, 2025 13:08
"@wc-toolkit/storybook-helpers": "9.0.1",
"autoprefixer": "10.4.21",
"glob": "11.0.3",
"playwright": "1.53.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is resolving to the version needed in first-gen… I’m ok with keeping parity for now but wanted to flag this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I think keeping parity is good for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But FYI, we already had

"resolutions": {
        "playwright": "1.53.1"
    },

@rubencarvalho rubencarvalho changed the title Ruben/pin dependencies chore(deps): pin package dependencies in 2nd-gen Oct 22, 2025
@rubencarvalho rubencarvalho marked this pull request as ready for review October 22, 2025 15:16
@rubencarvalho rubencarvalho requested a review from a team as a code owner October 22, 2025 15:16
@rubencarvalho rubencarvalho added Tooling Status: Ready for review PR ready for review or re-review. 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels Oct 22, 2025
Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following error when I run yarn test:

packages/tray/test/tray.test.js:

 🚧 Browser logs on Firefox:
      TypeError: error loading dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=OTMOYXsP3zhX9Dy9vkId2
 🚧 Browser logs on Chromium:
      TypeError: Failed to fetch dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=cMkGLxeferi-7tozR5SB2
 🚧 Browser logs on Webkit:
      TypeError: Importing a module script failed.

 ❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information. 

"react-dom": "19.1.1",
"rimraf": "6.0.1",
"storybook": "9.1.10",
"typescript": "5.9.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs a full TS build to check for regression. Laying this out here for other reviewers

Comment on lines +60 to +61
"@types/react": "19.1.16",
"@types/react-dom": "19.1.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason behind bumping "@types/react": "19.1.16" and not to 19.1.1? Shouldn't be a problem though if the ts build passes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the previously resolved version, so nothing changed here! :)

Screenshot 2025-10-23 at 22 20 02

@rubencarvalho
Copy link
Contributor Author

I'm getting the following error when I run yarn test:

packages/tray/test/tray.test.js:

 🚧 Browser logs on Firefox:
      TypeError: error loading dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=OTMOYXsP3zhX9Dy9vkId2
 🚧 Browser logs on Chromium:
      TypeError: Failed to fetch dynamically imported module: https://localhost:8000/packages/tray/test/tray.test.js?wtr-session-id=cMkGLxeferi-7tozR5SB2
 🚧 Browser logs on Webkit:
      TypeError: Importing a module script failed.

 ❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information. 

I could not reproduce this! Please make sure you run yarn install and then

cd second-gen/packages/core && yarn build

and then from first-gen/

yarn test

(this command orchestration is fixed on #5791)

Copy link
Contributor

@caseyisonit caseyisonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with rajdeeps call out for a fresh build with typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Status: Ready for review PR ready for review or re-review. Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants