Skip to content

fix(field-label): address edge case where required icon would not render on the same line(Safari only) #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

fix(field-label): address edge case where required icon would not render on the same line(Safari only) #5822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7152a1
fix(field-label): address edge case where required icon would not ren…
cdransf Oct 22, 2025
d723d35
chore(field-label): update golden hash
cdransf Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ parameters:
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: 94764405d1674838a93d6c6a39e793df39fc301e
default: 6e25ce9467fb1798f192578becb305b5d00ffb72
wireit_cache_name:
type: string
default: wireit
Expand Down
4 changes: 3 additions & 1 deletion packages/field-label/src/field-label.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,7 @@
@import url("./field-label-overrides.css");

label {
display: inline-block;
display: inline-flex;
align-items: baseline;
white-space: nowrap;
Copy link
Collaborator

@rise-erpelding rise-erpelding Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing that this longer field label example has stopped wrapping because we have nowrap on here, do we want the field label to wrap for situations like this?

Image

It doesn't seem like we have VRTs covering this situation as far as I can see, it would be good to address this gap in coverage too.

}
1 change: 1 addition & 0 deletions packages/field-label/src/spectrum-field-label.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
margin-inline: var(--mod-field-label-text-to-asterisk, var(--spectrum-field-label-text-to-asterisk)) 0;
vertical-align: initial;
vertical-align: var(--mod-field-label-asterisk-vertical-align, baseline);
flex-shrink: 0;
}

:host([side-aligned="start"]),
Expand Down
Loading