Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Oct 23, 2025

Description

Added first-gen and second-gen folders to .gitignore and .vscode file exclusion settings.

Motivation and context

While we're still working on the barebones branch, this will make switching between branches smoother.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Check out main after checking and building barebones. Verify there are no lingering unstaged files!

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

⚠️ No Changeset found

Latest commit: 888bf52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5824

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rubencarvalho rubencarvalho changed the title chore: git ignore first and second-gen folders chore: ignore first and second-gen folders Oct 23, 2025
@rubencarvalho rubencarvalho marked this pull request as ready for review October 23, 2025 20:31
@rubencarvalho rubencarvalho requested a review from a team as a code owner October 23, 2025 20:31
@github-actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18761099687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.966%

Totals Coverage Status
Change from base Build 18730825611: 0.0%
Covered Lines: 34249
Relevant Lines: 34778

💛 - Coveralls

@Rajdeepc Rajdeepc added the Status: Ready for review PR ready for review or re-review. label Oct 24, 2025
@rubencarvalho rubencarvalho merged commit 1c39f19 into main Oct 24, 2025
27 checks passed
@rubencarvalho rubencarvalho deleted the ruben/add-first-second-gen-to-gitignore branch October 24, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants