-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marketo Engage Person Details extension. #1797
Add Marketo Engage Person Details extension. #1797
Conversation
components/fieldgroups/profile/marketo-engage-person-details.schema.json
Outdated
Show resolved
Hide resolved
components/fieldgroups/profile/marketo-engage-person-details.schema.json
Outdated
Show resolved
Hide resolved
@ChrisRobbers , I have got few questions regarding this requirement. For B2B customers, there is a pre-provisioning script that is executed which sets all the schemas, their namespaces, identities and relationships at the time of deployment of a B2B sandbox. If this "cookieIDs" field is supposed to part of every B2B implementation then it should be added to that pre-provisioning script as well. Please reach out to the B2B product manager to understand the process. Additionally, if this is a needed property for all B2B implementations, can't we just add this to the existing field group "https://github.com/adobe/xdm/blob/master/components/fieldgroups/profile/b2b-person-details.schema.json". You can add it under the definition "b2b-person-details" as a child node to the ""xdm:b2b" object. Is there a business need to have this property defined under "marketoEngage" object ? If that is the case, then let's move this field group under this folder "https://github.com/adobe/xdm/tree/master/extensions/adobe/b2b" You can use "https://github.com/adobe/xdm/blob/master/extensions/adobe/b2b/bizible/bizible-person-details.schema.json" field group and its folder structure as reference cc: @anandphatak |
This will be an optional field group for customers who use Marketo Engage. It is intended to supply extra metadata to Marketo Measure Ultimate that will be used to supplement customer's existing integrations from Marketo Engage -> Marketo Measure. It will not be a requirement for any B2B customer, new or existing, but something they will optionally provide in their datasets which we integrate via a Marketo Measure Destination connector.
I don't think this should be required as per my description above.
The thinking is that this is the first of potentially more fields that are specific to Marketo Engage, thus the choice to group them under a "marketoEngage" object. We could have just created a field named "marketoEngageCookieIDs" at the "b2b" object level, but this will allow the potential for more fields to be grouped in the future, if that makes sense.
|
@mjasrotia given the above info, please let me know if I still should move the files to the extensions path. Thanks. |
@ChrisRobbers , considering that this is a customer specific requirement and since it would not be added to the prte-provisioning script, I think we should move it under the extensions folder and you can take bizible as an example |
Adding additional notes here from slack thread.
cc: @anandphatak , @ChrisRobbers |
@ChrisRobbers , please refresh your master to resolve the conflicts. See the build failure message |
@mjasrotia I have merged in master. Is there anything else you need, or can this be merged? |
This change is to add a new Marketo Engage-specific extension that will be used to decorate XDM Profile person records with fields that are unique to Marketo Engage. These fields will be used in Marketo Measure Ultimate to de-anonymize Marketo Measure-sourced web activity data with Marketo Engage Munchkin ID cookies.
Issue: #1795