(MINOR) Add new API function XmpFile::try_close which will report any error encountered when closing a file
#232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, @CeNiEi.
… encountered when closing a file Fixes crash reported in #230.
scouten-adobe
changed the title
XmpFile::try_close which will report any error encountered when closing a file
scouten-adobe
changed the title
XmpFile::try_close which will report any error encountered when closing a fileXmpFile::try_close which will report any error encountered when closing a file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 98.11% 98.12%
=======================================
Files 9 9
Lines 1857 1864 +7
=======================================
+ Hits 1822 1829 +7
Misses 35 35 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash reported in #230.
Thank you, @CeNiEi!