Ensures Carousel Card Edit This Template Button Works On Mobile #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fullcolorcoder
approved these changes
Dec 12, 2024
Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com>
echen-adobe
approved these changes
Dec 12, 2024
Merged
fullcolorcoder
added a commit
that referenced
this pull request
Dec 13, 2024
* MWPW-143385 archive puf & premium-plan blocks (#1284) * Allow Authors To Set Background Image in Banner (#1322) * allow bgImage to be authored for banner * CSS for bgImage * Ensures Carousel Card Edit This Template Button Works On Mobile (#1323) * ensure edit this template button works * Update express/blocks/shared/basic-carousel.js Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> --------- Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: jsandland <all48775@adobe.com>
echen-adobe
added a commit
that referenced
this pull request
Jan 13, 2025
* reverted single video variant * Update columns.css * Update columns.css * Update columns.css * Sync Stage to Main (#1325) * MWPW-143385 archive puf & premium-plan blocks (#1284) * Allow Authors To Set Background Image in Banner (#1322) * allow bgImage to be authored for banner * CSS for bgImage * Ensures Carousel Card Edit This Template Button Works On Mobile (#1323) * ensure edit this template button works * Update express/blocks/shared/basic-carousel.js Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> --------- Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: jsandland <all48775@adobe.com> * Mobile Fork Button Font Shrink Hotfix (#1331) * How To Steps Accordion (#1324) * how-to-steps-accordion.js * how-to-steps-accordion.css * remove $ from js code * mobile image aspect ratio maintained between screen sizes, max-width set to 400 * wip - mobile and tablet container sizing complete * all layout / positioning from mobile to desktop complete for image and video * ensures video is sized and centered for mobile, tablet and desktop * ensure hover only applies to header and not sub-text * set background from mobile to desktop * ensure background image looks consistent * use vw for top value for background to allow a dynamic position on window re-size - this prevents the bgImage from moving too low into the steps * rename to how-to-v2 * remove steps from name * update CSS classes to use new block name * adds margin-top to header of video container * Update mobile-fork-button.css * Update mobile-fork-button.css * Update mobile-fork-button.css * Update mobile-fork-button.css * ... * ... * Update mobile-fork-button.js * Update mobile-fork-button-frictionless.js * lint * removed this for now --------- Co-authored-by: jsandland <all48775@adobe.com> --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: jsandland <all48775@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following issues|Adds following features:
Resolves: MWPW-155657
Steps to test the before vs. after and expectations:
Before
After
Pages to check for regression and performance: