Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover V2 - Updates #1327

Closed
wants to merge 66 commits into from
Closed

Discover V2 - Updates #1327

wants to merge 66 commits into from

Conversation

jsandland
Copy link
Collaborator

@jsandland jsandland commented Dec 18, 2024

Fixes following issues|Adds following features:

  • Aligns mobile and desktop blog with Discover V2 Designs
  • Aligns banner light variant with Discover V2 Designs

Resolves: MWPW-163526

banner-remove-padding mobile-blog desktop-blog

Pages to check for regression and performance:

Copy link

aem-code-sync bot commented Dec 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates December 18, 2024 18:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates December 18, 2024 20:09 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates December 18, 2024 20:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates December 18, 2024 20:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates December 18, 2024 20:27 Inactive
Copy link

aem-code-sync bot commented Dec 18, 2024

Page Scores Audits
📱 /drafts/jsandlan/updated-discover PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /drafts/jsandlan/updated-discover PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 44.15%. Comparing base (0c5ee58) to head (a141885).
Report is 66 commits behind head on stage.

Files with missing lines Patch % Lines
express/blocks/blog-posts/blog-posts.js 0.00% 17 Missing ⚠️
express/blocks/columns/columns.js 22.22% 14 Missing ⚠️
express/blocks/shared/basic-carousel.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #1327      +/-   ##
==========================================
+ Coverage   42.72%   44.15%   +1.42%     
==========================================
  Files          97       96       -1     
  Lines       22896    22413     -483     
==========================================
+ Hits         9782     9896     +114     
+ Misses      13114    12517     -597     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 17:43 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 17:51 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 17:53 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 17:57 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 18:20 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 6, 2025 18:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 21, 2025 22:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 21, 2025 22:37 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 19:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 20:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 21:44 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 21:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:00 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:19 Inactive
…nt remains centered as viewport width increases
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:29 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 22, 2025 22:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 23, 2025 20:41 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to discover-page-updates January 23, 2025 21:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants