Skip to content

[ENB-7652] Refactor flags and methods #2644

[ENB-7652] Refactor flags and methods

[ENB-7652] Refactor flags and methods #2644

Triggered via pull request January 24, 2025 05:13
Status Success
Total duration 8m 25s
Artifacts

run-nala-default.yml

on: pull_request
Matrix: Running Nala E2E UI Tests
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 1 warning, and 1 notice
[milo-live-chromium] › blocks/review/review.test.js:34:7 › Milo Review Block test suite › [Test Id - 1] @Review low: nala/libs/accessibility.js#L126
1) [milo-live-chromium] › blocks/review/review.test.js:34:7 › Milo Review Block test suite › [Test Id - 1] @review low,@review @smoke @regression @milo › step-2: Verify the accessibility test on the review block AccessibilityError: [Accessibility Test failed for [Test Id - 1] @review low]. Accessibility test failed : 1 violation(s) found. ========== Accessibility Test ========== [Test Name ]: [Test Id - 1] @review low [Test Page URL]: https://enb-7652-refactor-enablepersev2--milo--swamu.aem.live/drafts/nala/blocks/review/review [Accessibility]: Running accessibility test on the provided locator: locator('.review') [Result ]: Accessibility test found 1 accessibility violation(s) for [Test Id - 1] @review low [Violation Details]: 1. Violation: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds - Axe Rule ID: color-contrast - Severity: serious - WCAG Tags: cat.color, wcag2aa, wcag143, TTv5, TT13.c, EN-301-549, EN-9.1.4.3, ACT - Nodes affected: 1. <h3 class="hlx-reviewTitle">Rate your Experience</h3> - Fix: https://dequeuniversity.com/rules/axe/4.10/color-contrast?application=playwright at libs/accessibility.js:126 124 | } 125 | } catch (err) { > 126 | throw new AccessibilityError( | ^ 127 | `[Accessibility Test failed for ${testName}].\n ${err.message}`, 128 | ); 129 | } at runAccessibilityTest (/home/runner/work/milo/milo/nala/libs/accessibility.js:126:11) at /home/runner/work/milo/milo/nala/blocks/review/review.test.js:44:7 at /home/runner/work/milo/milo/nala/blocks/review/review.test.js:43:5
[milo-live-chromium] › features/mas/benchmark/benchmark.test.js:17:7 › Benchmark feature test suite › @MAS-CCD-benchmark: nala/features/mas/benchmark/benchmark.test.js#L46
2) [milo-live-chromium] › features/mas/benchmark/benchmark.test.js:17:7 › Benchmark feature test suite › @MAS-CCD-benchmark,@MAS-CCD @merch-benchmark-ccd-cards @mas-benchmark @Commerce @smoke @regression @milo › step-2: Validate benchmark Error: 1518.1999999999825ms should be less than limit 697.0731707316789ms (adjusted from 400ms) expect(received).toBeTruthy() Received: false 44 | expect(times.length).toBeGreaterThan(0); 45 | times.forEach((time) => { > 46 | expect(parseFloat(time) < parseFloat(limit), `${time}ms should be less than limit ${limitMessage}`).toBeTruthy(); | ^ 47 | }); 48 | }); 49 | }); at forEach (/home/runner/work/milo/milo/nala/features/mas/benchmark/benchmark.test.js:46:109) at /home/runner/work/milo/milo/nala/features/mas/benchmark/benchmark.test.js:45:13 at /home/runner/work/milo/milo/nala/features/mas/benchmark/benchmark.test.js:27:5
[milo-live-webkit] › blocks/actionitem/actionitem.test.js:193:7 › Milo Action-Item block test suite › 7: @Action-item (scroller with navigation): nala/blocks/actionitem/actionitem.test.js#L211
3) [milo-live-webkit] › blocks/actionitem/actionitem.test.js:193:7 › Milo Action-Item block test suite › 7: @action-item (scroller with navigation), @action-item @smoke @regression @milo › step-2: Verify Action item content/specs Error: Timed out 1000ms waiting for expect(locator).toBeVisible() Locator: locator('.action-scroller').first().locator('.nav-grad.next').locator('.nav-button.next-button') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 1000ms - waiting for locator('.action-scroller').first().locator('.nav-grad.next').locator('.nav-button.next-button') - locator resolved to <button class="nav-button next-button">…</button> - unexpected value "hidden" - locator resolved to <button class="nav-button next-button">…</button> - unexpected value "hidden" - locator resolved to <button class="nav-button next-button">…</button> - unexpected value "hidden" - locator resolved to <button class="nav-button next-button">…</button> - unexpected value "hidden" 209 | await expect(await actionItem.bodyText).toContainText(data.bodyText); 210 | > 211 | await expect(await actionItem.nextButton).toBeVisible({ timeout: 1000 }); | ^ 212 | await actionItem.nextButton.click(); 213 | await expect(await actionItem.previousButton).toBeVisible({ timeout: 1000 }); 214 | await expect(await actionItem.navigationNext).toHaveAttribute('hide-btn', 'false'); at /home/runner/work/milo/milo/nala/blocks/actionitem/actionitem.test.js:211:49 at /home/runner/work/milo/milo/nala/blocks/actionitem/actionitem.test.js:203:5
Running Nala E2E UI Tests (20.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
🎭 Playwright Run Summary
3 flaky [milo-live-chromium] › blocks/review/review.test.js:34:7 › Milo Review Block test suite › [Test Id - 1] @review low,@review @smoke @regression @milo [milo-live-chromium] › features/mas/benchmark/benchmark.test.js:17:7 › Benchmark feature test suite › @MAS-CCD-benchmark,@MAS-CCD @merch-benchmark-ccd-cards @mas-benchmark @Commerce @smoke @regression @milo [milo-live-webkit] › blocks/actionitem/actionitem.test.js:193:7 › Milo Action-Item block test suite › 7: @action-item (scroller with navigation), @action-item @smoke @regression @milo 58 skipped 599 passed (7.4m)