Mobile gnav tests (#3433)

* Fixed unit tests for gnav promo * Prevent other tests from breaking * Added a test case for safari * Added an escape test for localnav
adobecom · Jan 8, 2025 · 3b4ee98 · 3b4ee98
1 parent 490a349
commit 3b4ee98
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 5 deletions.
diff --git a/test/blocks/global-navigation/global-navigation.test.js b/test/blocks/global-navigation/global-navigation.test.js
@@ -750,5 +750,17 @@ describe('global navigation', () => {
       headline.click();
       expect(headline.getAttribute('aria-expanded')).to.equal('true');
     });
+
+    it('adds the correct class when on Safari', async () => {
+      Object.defineProperty(navigator, 'userAgent', { get: () => 'Safari' });
+      await createFullGlobalNavigation({ globalNavigation: gnavWithlocalNav, viewport: 'mobile' });
+      const localNavTitle = document.querySelector(selectors.localNavTitle);
+      localNavTitle.click();
+      const localNav = document.querySelector(selectors.localNav);
+      const curtain = localNav.querySelector('.feds-localnav-curtain');
+      expect(document.body.classList.contains('disable-ios-scroll')).to.equal(true);
+      curtain.click();
+      expect(document.body.classList.contains('disable-ios-scroll')).to.equal(false);
+    });
   });
 });
diff --git a/test/blocks/global-navigation/gnav-promo.test.js b/test/blocks/global-navigation/gnav-promo.test.js
@@ -37,7 +37,7 @@ describe('Promo', () => {
   it('is available if set up correctly', async () => {
     const promoMeta = toFragment`<meta name="gnav-promo-source" content="http://localhost:2000/fragments/correct-promo-fragment">`;
     document.head.append(promoMeta);
-    const nav = await createFullGlobalNavigation({ hasPromo: true });
+    const nav = await createFullGlobalNavigation({ hasPromo: true, imsInitialized: true });
     expect(nav.block.classList.contains('has-promo')).to.be.true;
     const asideElem = nav.block.querySelector('.aside.promobar');
     expect(asideElem).to.exist;

diff --git a/test/blocks/global-navigation/keyboard/keyboard.test.js b/test/blocks/global-navigation/keyboard/keyboard.test.js
@@ -1144,6 +1144,17 @@ describe('keyboard navigation', () => {
         const localnavTitle = document.querySelector('.feds-localnav-title');
         expect(document.activeElement).to.equal(localnavTitle);
       });
+      it('closes when escape is pressed', async () => {
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Tab' });
+        await sendKeys({ press: 'Space' });
+        await sendKeys({ press: 'Escape' });
+        expect(document.querySelector('feds-localnav--active')).to.not.exist;
+      });
     });
   });
 });
diff --git a/test/blocks/global-navigation/test-utilities.js b/test/blocks/global-navigation/test-utilities.js
@@ -173,11 +173,9 @@ export const createFullGlobalNavigation = async ({
   hasPromo,
   hasBreadcrumbs = true,
   unavContent = null,
+  imsInitialized = false,
 } = {}) => {
-  const clock = sinon.useFakeTimers({
-    // Intercept setTimeout and call the function immediately
-    toFake: ['setTimeout'],
-  });
+  const clock = sinon.useFakeTimers({ shouldAdvanceTime: true });
   setConfig({ ...config, ...customConfig });
   await setViewport(viewports[viewport]);
   window.lana = { log: stub() };
@@ -198,6 +196,7 @@ export const createFullGlobalNavigation = async ({
     return null;
   });
   window.adobeIMS = {
+    initialized: imsInitialized,
     isSignedInUser: stub().returns(signedIn),
     getAccessToken: stub().returns('mock-access-token'),
     getProfile: stub().returns(
@@ -228,9 +227,11 @@ export const createFullGlobalNavigation = async ({
   const instancePromise = initGnav(document.body.querySelector('header'));
 
   await clock.runToLastAsync();
+  clock.tick(1000);
   const instance = await instancePromise;
   const imsPromise = instance.imsReady();
   await clock.runToLastAsync();
+  clock.tick(1000);
   // We restore the clock here, because waitForElement uses setTimeout
   clock.restore();