Merge branch 'mepanymarqueesection' of https://github.com/adobecom/milo…

… into mepanymarqueesection
adobecom · Sep 17, 2024 · 9f8b20d · 9f8b20d
2 parents e25168a + 4b1f438
commit 9f8b20d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/libs/features/personalization/personalization.js b/libs/features/personalization/personalization.js
@@ -373,7 +373,7 @@ function modifySelectorTerm(termParam) {
   const startText = startTextMatch ? startTextMatch[0].toLowerCase() : '';
   const startTextPart1 = startText.split(/\.|:/)[0];
   const endNumberMatch = term.match(/[0-9]*$/);
-  const endNumber = endNumberMatch ? endNumberMatch[0] : '';
+  const endNumber = endNumberMatch && startText.match(/^[a-zA-Z]/) ? endNumberMatch[0] : '';
   if (!startText || htmlEls.includes(startText)) return term;
   if (otherSelectors.includes(startText)) {
     term = term.replace(startText, '> div');

diff --git a/test/features/personalization/mocks/manifestSectionBlock.json b/test/features/personalization/mocks/manifestSectionBlock.json
@@ -5,7 +5,7 @@
   "data": [
     {
       "action": "removeContent",
-      "selector": ".custom-block1",
+      "selector": ".custom-block-1",
       "page filter (optional)": "",
       "param-newoffer=123": "",
       "all": "on"

diff --git a/test/features/personalization/modifyNonFragmentSelector.test.js b/test/features/personalization/modifyNonFragmentSelector.test.js
@@ -117,7 +117,7 @@ const values = [
   },
   {
     b: 'section1 .random-block2',
-    a: 'main > div:nth-child(1) .random-block:nth-child(2 of .random-block)',
+    a: 'main > div:nth-child(1) .random-block2',
   },
   {
     b: 'main > section30',
@@ -147,6 +147,10 @@ const values = [
     b: 'any-marquee-section',
     a: 'main > div:has([class*="marquee"])',
   },
+  {
+    b: '.aside03',
+    a: '.aside03',
+  },
 ];
 describe('test different values', () => {
   values.forEach((value) => {