Skip to content

Commit

Permalink
Gnav bugs (#3346)
Browse files Browse the repository at this point in the history
* Fixing mega menu CTA height

* Localnav z index and removing default makeActiveTab call
  • Loading branch information
bandana147 committed Jan 7, 2025
1 parent d04e14d commit cb64be6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 2 additions & 5 deletions libs/blocks/global-navigation/global-navigation.css
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,7 @@ header.new-nav .feds-nav > section.feds-navItem > .feds-popup .sticky-cta {

header.new-nav .feds-nav > section.feds-navItem.feds-dropdown--active > .feds-popup .sticky-cta a {
width: 320px;
height: 39px;
}

/* breadcrumbs new nav*/
Expand Down Expand Up @@ -1052,7 +1053,7 @@ header.new-nav .feds-breadcrumbs li:first-child:not(:nth-last-child(-n+3)):after
top: 0;
width: 100%;
left: 0;
z-index: 2;
z-index: 10;
}

.feds-localnav a {
Expand Down Expand Up @@ -1114,10 +1115,6 @@ header.new-nav .feds-breadcrumbs li:first-child:not(:nth-last-child(-n+3)):after
padding: 12px 56px;
}

.feds-localnav .feds-navLink[aria-expanded="true"] {
font-weight: 600;
}

.feds-localnav .feds-localnav-items .feds-navLink {
border-bottom: 0;
font-size: 14px;
Expand Down
1 change: 0 additions & 1 deletion libs/blocks/global-navigation/global-navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,6 @@ class Gnav {
if (!isDesktop.matches && this.newMobileNav && popup) {
originalContent = await transformTemplateToMobile(popup, item, this.isLocalNav());
popup.querySelector('.close-icon')?.addEventListener('click', this.toggleMenuMobile);
makeTabActive(popup);
}
isDesktop.addEventListener('change', async () => {
if (isDesktop.matches) {
Expand Down

0 comments on commit cb64be6

Please sign in to comment.