generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 175
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from adobecom/test-check
Add recommendations
- Loading branch information
Showing
4 changed files
with
34 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Please always provide the [GitHub issue(s)](../issues) your PR is for, as well as test URLs where your change can be observed (before and after): | ||
|
||
Fix #<gh-issue-id> | ||
Resolves: <gh-issue-id> | ||
|
||
Test URLs: | ||
- Before: https://main--<repo>--<owner>.hlx.page/ | ||
- After: https://<branch>--<repo>--<owner>.hlx.page/ | ||
- Before: https://main--milo--adobecom.hlx.page/ | ||
- After: https://<branch>--milo--adobecom.hlx.page/ |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,34 @@ | ||
# Run this action only for pull requests from this repository | ||
name: Tests | ||
|
||
name: Run tests | ||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened, edited] | ||
branches: | ||
- main | ||
|
||
jobs: | ||
build: | ||
if: github.repository_owner == 'adobe' # replace 'adobe' with repo owner | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [14.x] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Use Node.js | ||
uses: actions/setup-node@v3 | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 2 | ||
|
||
- name: Set up Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: '14' | ||
- run: npm install | ||
working-directory: test | ||
- run: npm run lint | ||
- run: npm test | ||
working-directory: test | ||
env: | ||
CI: true | ||
node-version: ${{ matrix.node-version }} | ||
|
||
- name: Install XVFB | ||
run: sudo apt-get install xvfb | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Run the tests | ||
run: xvfb-run -a npm test | ||
|
||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"recommendations": [ | ||
"stylelint.vscode-stylelint", | ||
"dbaeumer.vscode-eslint", | ||
"editorconfig.editorconfig", | ||
"ryanluker.vscode-coverage-gutters", | ||
"eamodio.gitlens" | ||
] | ||
} |