Skip to content

Commit

Permalink
Merge pull request #1 from adobecom/test-check
Browse files Browse the repository at this point in the history
Add recommendations
  • Loading branch information
auniverseaway authored Apr 10, 2022
2 parents 083f42a + b12f16a commit d9d0c00
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 43 deletions.
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Please always provide the [GitHub issue(s)](../issues) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #<gh-issue-id>
Resolves: <gh-issue-id>

Test URLs:
- Before: https://main--<repo>--<owner>.hlx.page/
- After: https://<branch>--<repo>--<owner>.hlx.page/
- Before: https://main--milo--adobecom.hlx.page/
- After: https://<branch>--milo--adobecom.hlx.page/
24 changes: 0 additions & 24 deletions .github/workflows/run-tests-on-fork.yaml

This file was deleted.

38 changes: 22 additions & 16 deletions .github/workflows/run-tests.yaml
Original file line number Diff line number Diff line change
@@ -1,28 +1,34 @@
# Run this action only for pull requests from this repository
name: Tests

name: Run tests
on:
pull_request:
types: [opened, synchronize, reopened, edited]
branches:
- main

jobs:
build:
if: github.repository_owner == 'adobe' # replace 'adobe' with repo owner
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js
uses: actions/setup-node@v3
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: 2

- name: Set up Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: '14'
- run: npm install
working-directory: test
- run: npm run lint
- run: npm test
working-directory: test
env:
CI: true
node-version: ${{ matrix.node-version }}

- name: Install XVFB
run: sudo apt-get install xvfb

- name: Install dependencies
run: npm install

- name: Run the tests
run: xvfb-run -a npm test

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
9 changes: 9 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"recommendations": [
"stylelint.vscode-stylelint",
"dbaeumer.vscode-eslint",
"editorconfig.editorconfig",
"ryanluker.vscode-coverage-gutters",
"eamodio.gitlens"
]
}

0 comments on commit d9d0c00

Please sign in to comment.