Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142894: Active element accessibility #1945

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

robert-bogos
Copy link
Contributor

@robert-bogos robert-bogos commented Mar 1, 2024

Description

This PR adds a fix for the global navigation active element accessibility.

Related Issue

Resolves: MWPW-140281

Testing instructions

  1. activate VoiceOver;
  2. go to the before MILO test URL and select the "Active element" link. You should hear: "Active element, group";
  3. go to the after MILO test URL and select the "Active element" link. You should hear: "Dimmed current page, link, Active element";

Test URLs

Acrobat:

BACOM:

CC:

Homepage:

Blog:

Milo:

@robert-bogos robert-bogos added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Mar 1, 2024
@robert-bogos robert-bogos self-assigned this Mar 1, 2024
Copy link
Contributor

aem-code-sync bot commented Mar 1, 2024

Page Scores Audits Google
/drafts/rbogos/page-active-element?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (b355d59) to head (550a60f).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #1945      +/-   ##
==========================================
- Coverage   96.42%   96.41%   -0.02%     
==========================================
  Files         166      166              
  Lines       43464    43467       +3     
==========================================
- Hits        41912    41910       -2     
- Misses       1552     1557       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn changed the base branch from main to stage March 1, 2024 22:49
@SilviuLCF SilviuLCF self-requested a review March 4, 2024 08:27
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for STAGE
Testing details https://jira.corp.adobe.com/browse/MWPW-140281

@SilviuLCF SilviuLCF added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 4, 2024
@honstar
Copy link
Contributor

honstar commented Mar 21, 2024

While this should be ready for stage, nala tests are currently failing. @robert-bogos , can you please check?

@robert-bogos robert-bogos added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Mar 22, 2024
@robert-bogos robert-bogos merged commit 3f176c0 into adobecom:stage Apr 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants