generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-143673: Load Milo fragment modals from co links #1972
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8a1d26f
MWPW-143673: Load Milo fragment modals from co links
yesil 205bc17
remove unused css
yesil a3d5ba2
force .page instead of .live for co link configs
yesil 7c231d0
force .page instead of .live for co link configs
yesil fe58171
force .page instead of .live for co link configs
yesil c30b1da
Merge branch 'stage' into MWPW-143673
yesil bf11106
update price literals URL
yesil c074ecc
fix tests
yesil f9fd110
fix broken tests
yesil 709b622
Merge branch 'stage' into MWPW-143673
yesil 8b952cf
update style
yesil d91938b
consume latest commerce version
yesil 633a008
align response values
yesil 1650ed9
Merge branch 'stage' into MWPW-143673
yesil e481595
align response values
yesil 7e714d1
align response values
yesil 1e943a1
hide fragment during loadArea
yesil 52edd47
wip
yesil 03ae33f
update commerce api
yesil 7338d29
MWPW-143673: Load Milo fragment modals from co links
yesil dcd9c7c
Merge branch 'stage' into MWPW-143673
yesil 4c55cf8
update commerce lib
yesil cc60f6d
ignore untestable line from codecov
yesil 63b9215
ignore untestable line from codecov
yesil 56d956d
remove js.map file
yesil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<body> | ||
<div> | ||
<h1>twp modal #2</h1> | ||
</div> | ||
</body> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<body> | ||
<div> | ||
<h1>twp modal</h1> | ||
</div> | ||
</body> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to move this rule on line 206 (into the @media (max-width: 1200px) {}), otherwise it is applied on the desktop and makes the modal content height too big (adds a scroll). I added this change in this PR, but not sure which one will be merged first :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirafedas
the
>
in the rule is still needed because otherwise they apply to all the nested fragments and breaks the page.Since you have an iframe you didn't notice it.
Can you add
>
in yours?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for info, I didn't know, I'll add it