-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Video close events and modal window close events , send adobe_corpnew.digitalData in the alloy call #1998
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #1998 +/- ##
==========================================
+ Coverage 96.38% 96.41% +0.02%
==========================================
Files 166 166
Lines 43448 43449 +1
==========================================
+ Hits 41878 41890 +12
+ Misses 1570 1559 -11 ☔ View full report in Codecov by Sentry. |
|
closing. @Ruchika4 will submit a new PR to address this issue |
As an analyst, I want to have adobe_corpnew.digitalData in all video close or modal window close alloy tags so that reporting can be done using member id and other data points which are collected under digitalData object.
Context:
IF we visit the page https://business.adobe.com/products/real-time-customer-data-platform/rtcdp.html, and start the video and then close it, the alloy call on video close doesn't have data._adobe_corpnew. Similarly, if I change the region and the close the modal , I don't see data._adobe_corpnew in the payload.
Solution, add a daa-ll attribute to the close button.
Resolves: MWPW-139435
Test URLs:
Click the Watch overview button and then right click to inspect the close button in the top right. After link should have a daa-ll attribute.