Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Video close events and modal window close events , send adobe_corpnew.digitalData in the alloy call #1998

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

vgoodric
Copy link
Contributor

@vgoodric vgoodric commented Mar 13, 2024

As an analyst, I want to have adobe_corpnew.digitalData in all video close or modal window close alloy tags so that reporting can be done using member id and other data points which are collected under digitalData object.
Context:
IF we visit the page https://business.adobe.com/products/real-time-customer-data-platform/rtcdp.html, and start the video and then close it, the alloy call on video close doesn't have data._adobe_corpnew. Similarly, if I change the region and the close the modal , I don't see data._adobe_corpnew in the payload.

Solution, add a daa-ll attribute to the close button.

Resolves: MWPW-139435

Test URLs:
Click the Watch overview button and then right click to inspect the close button in the top right. After link should have a daa-ll attribute.

@vgoodric vgoodric added trivial PR doesn't require E2E testing by a reviewer run-nala Run Nala Test Automation against PR labels Mar 13, 2024
Copy link
Contributor

aem-code-sync bot commented Mar 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to analyticsclosemodal March 13, 2024 03:50 Inactive
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (94d3586) to head (53529f2).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #1998      +/-   ##
==========================================
+ Coverage   96.38%   96.41%   +0.02%     
==========================================
  Files         166      166              
  Lines       43448    43449       +1     
==========================================
+ Hits        41878    41890      +12     
+ Misses       1570     1559      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Mar 13, 2024

@vgoodric vgoodric requested review from robert-bogos, narcis-radu, vladen and a team March 13, 2024 04:16
@aem-code-sync aem-code-sync bot temporarily deployed to analyticsclosemodal March 13, 2024 19:25 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to analyticsclosemodal March 13, 2024 19:29 Inactive
@vgoodric vgoodric requested a review from Ruchika4 March 13, 2024 19:30
@skumar09 skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Mar 14, 2024
@vgoodric vgoodric closed this Mar 19, 2024
@vgoodric
Copy link
Contributor Author

closing. @Ruchika4 will submit a new PR to address this issue

@vgoodric vgoodric deleted the analyticsclosemodal branch March 19, 2024 08:14
@vgoodric vgoodric restored the analyticsclosemodal branch March 22, 2024 17:11
@aem-code-sync aem-code-sync bot temporarily deployed to analyticsclosemodal March 22, 2024 17:11 Inactive
@vgoodric vgoodric reopened this Mar 22, 2024
@vgoodric vgoodric added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Mar 30, 2024
@JasonHowellSlavin JasonHowellSlavin merged commit cf964ca into stage Apr 1, 2024
16 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the analyticsclosemodal branch April 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage run-nala Run Nala Test Automation against PR trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants