MWPW-144549 CTA alignment for Text, Icon, and Media Blocks

[meganthecoder]

• Align CTAs of Text, Icon, and Media blocks in "-up" sections

Resolves: MWPW-144549

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/drafts/methomas/text-alignment
• After: https://methomas-text-alignment--milo--adobecom.hlx.page/drafts/methomas/text-alignment?martech=off

Bacom:

• Before: https://main--bacom--adobecom.hlx.live/products/experience-manager/assets/pricing
• After: https://main--bacom--adobecom.hlx.live/products/experience-manager/assets/pricing?milolibs=methomas-text-alignment
• Before: https://main--bacom--adobecom.hlx.live/
• After: https://main--bacom--adobecom.hlx.live/?milolibs=methomas-text-alignment

Kitchen sink:

• Text: https://methomas-text-alignment--milo--adobecom.hlx.page/docs/library/kitchen-sink/text
• Icon: https://methomas-text-alignment--milo--adobecom.hlx.page/docs/library/kitchen-sink/icon-block
• Media: https://methomas-text-alignment--milo--adobecom.hlx.page/docs/library/kitchen-sink/media

Edge cases and regression:

• https://methomas-text-alignment--milo--adobecom.hlx.page/drafts/methomas/text-alignment-all

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• f453b19 ✅ (latest)
• deb24b3 ✅
• 8f860d2 ✅
• d9621f3 ✅
• ea8c013 ✅
• 78d83d0 ✅
• 2b21ca9 ✅
• adf35f8 ✅
• 9be1f58 ✅
• 322f6a5 ✅
• 2dae56e ✅
• bc809e6 ✅
• ee76fd5 ✅
• 17b1c3a ✅
• 5c13efe ✅
• f3a1a3b ✅
• 2be1a8a ✅
• a3c263a ✅
• 1625d98 ✅
• 597e26d ✅
• f7edd6f ✅

[aem-code-sync]

Page	Scores	Audits	Google
/docs/library/kitchen-sink/icon-block
/docs/library/kitchen-sink/media
/docs/library/kitchen-sink/text
/drafts/methomas/text-alignment-all
/drafts/methomas/text-alignment?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (55ad0f1) to head (f453b19).

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #2098   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         165      165           
  Lines       43523    43548   +25     
=======================================
+ Hits        42062    42089   +27     
+ Misses       1461     1459    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JasonHowellSlavin]

LGTM.

Really like that you included Kitchen Sink for verification!

[meganthecoder]

I'm closing this pull request for now because I've found some edge cases to account for. I'll re-open when it's ready to look at again. Thanks!

[meganthecoder]

I've reopened the PR, and it's ready for review!
Here's a lengthier test page of mostly edge cases. I added all variants, even ones that are unlikely to be used in the "-up" pattern: https://methomas-text-alignment--milo--adobecom.hlx.page/drafts/methomas/text-alignment-all

[robert-bogos]

Hi @meganthecoder ! I see that the unit tests check is failing, can you please look into that?

[meganthecoder]

@robert-bogos The unit tests are passing now, so I'm adding back the Ready for Stage label. In any case, the failed unit tests were for bulk-publish-v2 and unrelated to this PR.

[meganthecoder]

Looks like this won't get out today, so I'll put it on hold until I get back from PTO

[github-actions]

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.