Merging inline-block to milo branch for further updates #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and inaugurating first custom action for replacing cards in collection
mokimo
added a commit
that referenced
this pull request
May 8, 2024
… the gnav file (#2252) * Merging inline-block to milo branch for further updates (#2170) * MWPW-135821 introduce custom action - and inaugurating first custom action for replacing cards in collection * MWPW-135821 use prefix in selector * MWPW-135821 adding preview data --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> * initial commit with TODO * registerCustomAction updated * fragment, highlight fragment and merch-card update * chain fragment support added * inBlock fragments with URL and path as keys * css selectors starting to work * Add forceInline to handleCommands * stash * unit tests mostly done * fix mocking issue * add martech-metadata to unit test mock and check for replace * change name of registerCustomAction to registerInBlockActions * indent issue * remove mep useBlockCode Example * merch-card-collection-fix * update merch-card-collection unit test * ignore lines that cannot be reached by unit tests * rename CUSTOM_SELECTOR_PREFIX * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * call addHash once, not twice * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging inline-block to milo branch for further updates