Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-145721 UNav Analytics Enhancements #2256

Closed
wants to merge 2 commits into from
Closed

MWPW-145721 UNav Analytics Enhancements #2256

wants to merge 2 commits into from

Conversation

sonawanesnehal3
Copy link
Contributor

Copy link
Contributor

aem-code-sync bot commented May 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@sonawanesnehal3 sonawanesnehal3 added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (fa5f12a) to head (0d76324).
Report is 155 commits behind head on stage.

❗ Current head 0d76324 differs from pull request most recent head 6c5a52e. Consider uploading reports for the commit 6c5a52e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2256      +/-   ##
==========================================
- Coverage   96.36%   95.74%   -0.63%     
==========================================
  Files         166      165       -1     
  Lines       42531    43559    +1028     
==========================================
+ Hits        40986    41704     +718     
- Misses       1545     1855     +310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels May 3, 2024
@spadmasa spadmasa self-assigned this May 3, 2024
@Blainegunn
Copy link
Contributor

@sonawanesnehal3 this is in the next batch.

  • Project pep #2235 is a high-priority which also touches global-navigation.js.
    Thank you

Copy link
Contributor

aem-code-sync bot commented May 7, 2024

Page Scores Audits Google
/drafts/sghimpos/gnav-refactor?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sonawanesnehal3
Copy link
Contributor Author

Closing this PR as gnav branch needs to be used for other POC. Raising another PR from gnav2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants