MWPW-148253 Quiz Entry Coverage #2305

fullcolorcoder · 2024-05-14T16:01:56Z

Improves test coverage on quiz-entry block

Test URLs:
Before: https://quiz-entry-block--milo--adobecom.hlx.page/drafts/colloyd/quiz-entry/?martech=off
After: https://quiz-entry-block--milo--fullcolorcoder.hlx.page/drafts/colloyd/quiz-entry/?martech=off

…becom#2095)

* MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button

* MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object

* resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034)

* Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036)

* MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks

* carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes

* add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off

* MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet

aem-code-sync · 2024-05-14T16:02:16Z

Page	Scores	Audits	Google
/drafts/colloyd/quiz-entry/?martech=off

libs/blocks/quiz-entry/quizoption.js

libs/blocks/quiz-entry/utils.js

robert-bogos · 2024-05-15T08:36:35Z

libs/blocks/quiz-entry/utils.js

+      const jsonSelectionSelectedQustion = JSON.stringify(selection.selectedQuestion);
+      const jsonSelectedQuesion = JSON.stringify(selectedQuestion[0].selectedQuestion);
+      const isSameQuestion = jsonSelectionSelectedQustion === jsonSelectedQuesion;
+      if (isSameQuestion) {


I think we can skip caching here and reduce the lines of code.

Suggested change

const jsonSelectionSelectedQustion = JSON.stringify(selection.selectedQuestion);

const jsonSelectedQuesion = JSON.stringify(selectedQuestion[0].selectedQuestion);

const isSameQuestion = jsonSelectionSelectedQustion === jsonSelectedQuesion;

if (isSameQuestion) {

if (JSON.stringify(selection.selectedQuestion) === JSON.stringify(selectedQuestion[0].selectedQuestion)) {

robert-bogos · 2024-05-15T08:50:52Z

test/blocks/quiz-entry/quiz-entry.test.js

+    const rightArrowEvent = new KeyboardEvent('keydown', { key: 'ArrowRight' });
+    const leftArrowEvent = new KeyboardEvent('keydown', { key: 'ArrowLeft' });
+    carousel.dispatchEvent(rightArrowEvent);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    carousel.dispatchEvent(leftArrowEvent);


Nit: Same here, we can skip caching

Suggested change

const rightArrowEvent = new KeyboardEvent('keydown', { key: 'ArrowRight' });

const leftArrowEvent = new KeyboardEvent('keydown', { key: 'ArrowLeft' });

carousel.dispatchEvent(rightArrowEvent);

await new Promise((resolve) => setTimeout(resolve, 100));

carousel.dispatchEvent(leftArrowEvent);

carousel.dispatchEvent(new KeyboardEvent('keydown', { key: 'ArrowRight' }));

await new Promise((resolve) => setTimeout(resolve, 100));

carousel.dispatchEvent(new KeyboardEvent('keydown', { key: 'ArrowLeft' }));

robert-bogos · 2024-05-15T08:52:17Z

test/blocks/quiz-entry/quiz-entry.test.js

+    const leftArrow = document.querySelector('.carousel-arrow.arrow-prev');
+    expect(leftArrow).to.not.exist;


Nit: Same here, we can skip caching

Suggested change

const leftArrow = document.querySelector('.carousel-arrow.arrow-prev');

expect(leftArrow).to.not.exist;

expect(document.querySelector('.carousel-arrow.arrow-prev')).to.not.exist;

robert-bogos · 2024-05-15T08:56:39Z

test/blocks/quiz-entry/quiz-entry.test.js

+    const tabKeyEvent = new KeyboardEvent('keydown', { key: 'Tab' });
+    option.dispatchEvent(tabKeyEvent);


Nit: Same here, we can skip caching. There are many optimising opportunities like this in the file, I won't add a comment for all of them. This is just a possible improvement to the code compactness, nothing critical.

Suggested change

const tabKeyEvent = new KeyboardEvent('keydown', { key: 'Tab' });

option.dispatchEvent(tabKeyEvent);

option.dispatchEvent(new KeyboardEvent('keydown', { key: 'Tab' }));

overmyheadandbody

A few nits. Thanks a lot for raising the code coverage on this feature!

overmyheadandbody · 2024-05-15T09:24:04Z

libs/blocks/quiz-entry/quiz-entry.js

@@ -4,6 +4,12 @@ import { mlField, getMLResults } from './mlField.js';
 import { GetQuizOption } from './quizoption.js';
 import { quizPopover, getSuggestions } from './quizPopover.js';

+export const locationWrapper = {
+  redirect: (url) => {
+    window.location = url;


Have you considered assign? It may be useful to navigate back, if that's desired.

overmyheadandbody · 2024-05-15T09:25:01Z

test/blocks/quiz-entry/mocks/mock-data.js

@@ -100,7 +100,7 @@ const resultsMock = {
          options: 'photo',
          title: 'Photography',
          text: 'Edit or organize my photos',
-          icon: '',
+          icon: 'https://milo.adobe.com/drafts/quiz/quiz-ai/search.svg',


Does this ever get loaded? If so, it should be switched to a mock resource

overmyheadandbody · 2024-05-15T09:26:11Z

test/blocks/quiz-entry/quiz-entry.test.js

@@ -156,4 +156,147 @@ describe('Quiz Entry Component', () => {
    await new Promise((resolve) => setTimeout(resolve, 100));
    expect(continueButton.classList.contains('disabled')).to.be.false;
  });
+  it('should navigate the carousel using keyboard commands', async () => {
+    const options = document.querySelectorAll('.quiz-option');
+    const option = document.querySelector('.quiz-option');


Wouldn't this just be options[0]?

overmyheadandbody · 2024-05-15T09:32:18Z

test/blocks/quiz-entry/quiz-entry.test.js

+    const options = document.querySelectorAll('.quiz-option');
+    const option = document.querySelector('.quiz-option');
+    option.click();
+    await new Promise((resolve) => setTimeout(resolve, 100));


I'm not a big fan of having timeouts in unit tests, as they tend to add up and then the test suite takes a long time to run. I think there was a way around this with clock.runAllAsync() or something of the sort. In total this file adds around 2s of wait time. Multiply that by more such files and our PR checks will take a bit too much time to run.

This reverts commit ed79630.

* Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (adobecom#2095) * Quiz entry block (adobecom#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (adobecom#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (adobecom#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (adobecom#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (adobecom#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (adobecom#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (adobecom#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (adobecom#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Improved test coverage * resolve conflicts * restore style * formatting fix --------- Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com>

* [Release] Stage to Main (#2299) * MWPW-147599: CaaS Bulk Publisher not working after MS authentication change (#2248) Potential fix for bulk publisher issues Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> * Preflight Accessibility tab update (#2254) Updating how alt text is used and displayed in preflight Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146407: add new card style to caas configurator (#2279) Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> * MWPW-141780 - Clean up Accordion block attributes (#2276) remove role attribute on dd elements Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147158: adds support for footer divider at the collection level (#2198) * MWPW-147158: adds support for footer divider at the collection level * Updatest unit-test files * Update windows copy hash * Update OSX copy hash * Updates OSX hash again * Removes console log * Adds console logs for debbuging * Removes console logs * Adds console logs for debbuging again * Removes console log * Updates OSX hash * Adds debuging message to test * Update os-hash check logic * trim() generated hash * Changes the comparison logic for the hash * Reverts last attempt * new attempt to fix test --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147594: Consumers mappings for origin not being sent when using sidekick (#2244) * Fix for origin always being upper cased * Update tools/send-to-caas/send-utils.js changing to const Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * Stage automation, update the body after merging another PR in (#2289) * Stage process improvements * Remove team reviewers * Formatting * Simplify PR bodies --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Remove label requirements & merge workflows (#2288) Remove label & merge workflows Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Quiz entry block (#2294) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * Small font size fixes that design has asked for * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * added quiz-entry to utils.js (#2296) Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-148206: Update Spectra ML host from cchome-dev to cchome for PROD --------- Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> --------- Co-authored-by: Sanjay Rai <sanrai@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> * Revert "MWPW-141725 Graybox Block (#2282)" This reverts commit 7c47541. * Revert "MWPW-148253 Quiz Entry Coverage (#2305)" This reverts commit ed79630. * Revert "Revert "MWPW-141725 Graybox Block (#2282)"" This reverts commit e14572a. * MWPW-148253 Quiz Entry Coverage (#2305) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Improved test coverage * resolve conflicts * restore style * formatting fix --------- Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Sanjay Rai <sanrai@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> Co-authored-by: Cody Lloyd <colloyd@adobe.com>

* MWPW-147599: CaaS Bulk Publisher not working after MS authentication change (#2248) Potential fix for bulk publisher issues Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> * Preflight Accessibility tab update (#2254) Updating how alt text is used and displayed in preflight Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146407: add new card style to caas configurator (#2279) Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> * MWPW-141780 - Clean up Accordion block attributes (#2276) remove role attribute on dd elements Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147158: adds support for footer divider at the collection level (#2198) * MWPW-147158: adds support for footer divider at the collection level * Updatest unit-test files * Update windows copy hash * Update OSX copy hash * Updates OSX hash again * Removes console log * Adds console logs for debbuging * Removes console logs * Adds console logs for debbuging again * Removes console log * Updates OSX hash * Adds debuging message to test * Update os-hash check logic * trim() generated hash * Changes the comparison logic for the hash * Reverts last attempt * new attempt to fix test --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147594: Consumers mappings for origin not being sent when using sidekick (#2244) * Fix for origin always being upper cased * Update tools/send-to-caas/send-utils.js changing to const Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * Stage automation, update the body after merging another PR in (#2289) * Stage process improvements * Remove team reviewers * Formatting * Simplify PR bodies --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Remove label requirements & merge workflows (#2288) Remove label & merge workflows Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Quiz entry block (#2294) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * Small font size fixes that design has asked for * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * added quiz-entry to utils.js (#2296) Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-148206: Update Spectra ML host from cchome-dev to cchome for PROD --------- Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> * MWPW-147472: auto adjust commerce iframe (#2251) * MWPW-147472: auto adjust commerce iframe. * typo fix * fix for potential bfcache issues * improve modal selector query w.r.t hash improve test. --------- Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> * MWPW-141725 Graybox Block (#2282) * Initial graybox overlay * Add title & desc support * Use more variables * Add tests; fix issues found with tests * Add blue design changes + body outline * Fix blue border on device preview. Small bug fixes. * Only enable on -graybox urls or with graybox url param * Update graybox check to use hostname instead of path * Small bug fixes to handle when graybox url param already present * Add check for localhost for unit tests * PR feedback * Add metadata check; code cov tweaks * Change metadata setting * add .page/.live selector * Disable georouting modal when graybox is enabled --------- Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * MWPW-148253 Quiz Entry Coverage (#2305) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Improved test coverage * resolve conflicts * restore style * formatting fix --------- Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> * Revert "MWPW-141725 Graybox Block (#2282)" This reverts commit 7c47541. * Revert "MWPW-148253 Quiz Entry Coverage (#2305)" This reverts commit ed79630. * Revert "Revert "MWPW-141725 Graybox Block (#2282)"" This reverts commit e14572a. * MWPW-148253 Quiz Entry Coverage (#2305) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Improved test coverage * resolve conflicts * restore style * formatting fix --------- Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> * Merge main into stage to resolve history issues (#2310) * [Release] Stage to Main (#2299) * MWPW-147599: CaaS Bulk Publisher not working after MS authentication change (#2248) Potential fix for bulk publisher issues Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> * Preflight Accessibility tab update (#2254) Updating how alt text is used and displayed in preflight Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146407: add new card style to caas configurator (#2279) Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> * MWPW-141780 - Clean up Accordion block attributes (#2276) remove role attribute on dd elements Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147158: adds support for footer divider at the collection level (#2198) * MWPW-147158: adds support for footer divider at the collection level * Updatest unit-test files * Update windows copy hash * Update OSX copy hash * Updates OSX hash again * Removes console log * Adds console logs for debbuging * Removes console logs * Adds console logs for debbuging again * Removes console log * Updates OSX hash * Adds debuging message to test * Update os-hash check logic * trim() generated hash * Changes the comparison logic for the hash * Reverts last attempt * new attempt to fix test --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * MWPW-147594: Consumers mappings for origin not being sent when using sidekick (#2244) * Fix for origin always being upper cased * Update tools/send-to-caas/send-utils.js changing to const Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * Stage automation, update the body after merging another PR in (#2289) * Stage process improvements * Remove team reviewers * Formatting * Simplify PR bodies --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Remove label requirements & merge workflows (#2288) Remove label & merge workflows Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Quiz entry block (#2294) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * Small font size fixes that design has asked for * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * added quiz-entry to utils.js (#2296) Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-148206: Update Spectra ML host from cchome-dev to cchome for PROD --------- Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> --------- Co-authored-by: Sanjay Rai <sanrai@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> * Revert "MWPW-141725 Graybox Block (#2282)" This reverts commit 7c47541. * Revert "MWPW-148253 Quiz Entry Coverage (#2305)" This reverts commit ed79630. * Revert "Revert "MWPW-141725 Graybox Block (#2282)"" This reverts commit e14572a. * MWPW-148253 Quiz Entry Coverage (#2305) * Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Improved test coverage * resolve conflicts * restore style * formatting fix --------- Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> --------- Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Sanjay Rai <sanrai@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> Co-authored-by: Cody Lloyd <colloyd@adobe.com> * Revert "MWPW-147472: auto adjust commerce iframe" (#2312) Revert "MWPW-147472: auto adjust commerce iframe (#2251)" This reverts commit 481bbcb. * OPT-26580 DC0994_US | Frictionless | Add sticky banner Upload CTA (#2298) * 05-13-24 ivan dc0944 first * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * 05-13-24 ivan dc0944 add css changes and js optimization * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Update libs/mep/dc0944/aside/aside.js Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * 05-14-24 ivan renamed mep test folder dc0994 * 05-14-24 ivan fix sticky banner close btn --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com> --------- Co-authored-by: Sanjay Rai <sanrai@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Sheridan Sunier <sunier92@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Jacky Sun <67350368+JackySun9@users.noreply.github.com> Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jacky Sun <XIASUN@ADOBE.COM> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com> Co-authored-by: Cody Lloyd <colloyd@adobe.com> Co-authored-by: Okan Sahin <osahin@adobe.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com>

colloyd and others added 25 commits March 22, 2024 13:02

Initial quiz-entry block with ml field

1b2e32c

MWPW-144810: Quiz Entry - Add option cards and text to the block (ado…

fdee326

…becom#2095)

Quiz entry block (adobecom#2103)

e5f85f7

* MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button

MWPW-146034 - Quiz entry block accessibility (adobecom#2139)

b536cc2

* resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034)

MWPW-146036 - Rig up quiz entry button (adobecom#2190)

07a349f

* Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036)

MWPW-144022: Quiz entry block (adobecom#2227)

9496008

* carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes

carousel starts

aff5965

got buttons working

6b3f521

MWPW-144022: Prototype carousel refinement, keybord controls updated

1646ab3

linting fixes

b2990db

Tests

f0dd5ec

working tests update

a4bcd7c

linting

3a09e65

linting

6aee0ea

Update quiz-entry.js with default vals

18677b3

Bring back debug

5c543a4

debugging debug

49b0bc2

Improved test coverage

a0b27ca

resolve conflicts

0e652ce

resolve conflicts

e9ac496

restore style

c1b6e52

fullcolorcoder requested review from JackySun9, jedjedjedM and colloyd May 14, 2024 16:01

formatting fix

afd32b1

JackySun9 reviewed May 14, 2024

View reviewed changes

libs/blocks/quiz-entry/quizoption.js Show resolved Hide resolved

JackySun9 reviewed May 14, 2024

View reviewed changes

libs/blocks/quiz-entry/utils.js Show resolved Hide resolved

JackySun9 approved these changes May 14, 2024

View reviewed changes

colloyd approved these changes May 14, 2024

View reviewed changes

JackySun9 self-assigned this May 14, 2024

JackySun9 added verified PR has been E2E tested by a reviewer Ready for Stage new-feature New block or other feature labels May 14, 2024

robert-bogos approved these changes May 15, 2024

View reviewed changes

overmyheadandbody approved these changes May 15, 2024

View reviewed changes

milo-pr-merge bot merged commit ed79630 into adobecom:stage May 15, 2024
12 checks passed

milo-pr-merge bot mentioned this pull request May 15, 2024

[Release] Stage to Main #2309

Merged

mokimo added a commit to mokimo/milo that referenced this pull request May 15, 2024

Revert "MWPW-148253 Quiz Entry Coverage (adobecom#2305)"

798fa24

This reverts commit ed79630.

milo-pr-merge bot mentioned this pull request May 16, 2024

[Release] Stage to Main #2318

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-148253 Quiz Entry Coverage #2305

MWPW-148253 Quiz Entry Coverage #2305

fullcolorcoder commented May 14, 2024

aem-code-sync bot commented May 14, 2024 •

edited

Loading

robert-bogos May 15, 2024

robert-bogos May 15, 2024

robert-bogos May 15, 2024

robert-bogos May 15, 2024

overmyheadandbody left a comment

overmyheadandbody May 15, 2024

overmyheadandbody May 15, 2024

overmyheadandbody May 15, 2024

overmyheadandbody May 15, 2024

		const leftArrow = document.querySelector('.carousel-arrow.arrow-prev');
		expect(leftArrow).to.not.exist;

	const leftArrow = document.querySelector('.carousel-arrow.arrow-prev');
	expect(leftArrow).to.not.exist;
	expect(document.querySelector('.carousel-arrow.arrow-prev')).to.not.exist;

		const tabKeyEvent = new KeyboardEvent('keydown', { key: 'Tab' });
		option.dispatchEvent(tabKeyEvent);

	const tabKeyEvent = new KeyboardEvent('keydown', { key: 'Tab' });
	option.dispatchEvent(tabKeyEvent);
	option.dispatchEvent(new KeyboardEvent('keydown', { key: 'Tab' }));

MWPW-148253 Quiz Entry Coverage #2305

MWPW-148253 Quiz Entry Coverage #2305

Conversation

fullcolorcoder commented May 14, 2024

aem-code-sync bot commented May 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

overmyheadandbody left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aem-code-sync bot commented May 14, 2024 •

edited

Loading