-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High Impact Alert Workflow #2346
High Impact Alert Workflow #2346
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! The only use-case I'm thinking off is adding/removing labels, which would send multiple messages.
We can't easily verify a message has/hasn't already been sent though, since actions are stateless and we can't access slack.
So we need a bit of contributor education to avoid multiple messages because of adding and removing the label
I think most non-stage PRs get just one batch of labels, so we'll have to test this in the wild and see if it pollutes the Slack channel. The workflow could add its own label, say |
Reminder to set the |
I think workflow's cant be merged automatically 😕 That's just a guess though. Some PRs get this error:
We'll need to watch this. It sounds like a security feature so that workflows can't elevate their permissions and take over a repo |
This defines a new workflow that sends notifications to a Slack channel as soon as a PR with a
high-impact
label is opened. The previous logic from themerge-to-stage.js
script has been removed, since we want such a notification to be sent out as soon as the PR is opened, not when it eventually reaches thestage
branch, to ensure it gets visibility early on. Additionally, some workflows have been adapted to only run if the owner isadobecom
to reduce workflow runs on forks.Resolves: MWPW-148268
Test URLs: