MWPW-150566 - 🆕 Editorial-Card block #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokimo
reviewed
Jul 15, 2024
mokimo
reviewed
Jul 15, 2024
mokimo
reviewed
Jul 15, 2024
robert-bogos
approved these changes
Jul 15, 2024
|
@mokimo @robert-bogos - Thanks for the feedback. |
mokimo
approved these changes
Jul 16, 2024
NadiiaSokolova
approved these changes
Jul 16, 2024
narcis-radu
reviewed
Jul 16, 2024
|
Skipped 2533: MWPW-150566 - 🆕 Editorial-Card block due to file overlap. Merging will be attempted in the next batch |
|
Removing Ready for Stage label due to Narcis' last comment |
|
This PR is currently in the |
|
@elan-tbx maybe you can check the comments |
|
@narcis-radu ready for re-review when you get a chance! |
narcis-radu
approved these changes
Jul 23, 2024
|
No issues were found after the latest changes. Ready for Stage. |
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Jul 26, 2024
* stage: MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) MWPW-146743 Improve Article Header Performance (adobecom#2577) MWPW-153808: fix duplicate tax label (adobecom#2614) MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565) Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611) [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605) [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599) MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604) [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597) MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533) # Conflicts: # libs/deps/merch-card.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an author in Milo, I want the ability to add an
editorial cardblock to any Milo page.This is a net new block and not related to the 'card, merch-card, or cass' authoring or styles.
These are designed to work w/ the ups section metadata styles for their grid layouts, though the intent is to be grid agnostic.
Note on cross-team collaboration: I have added a new file 'iconography.css'. This is conditionally loaded if a block content needs
lockupstyles. (.avatar to be added in different PR)Figma design
Frontend
Document table model
Resolves: MWPW-150566
Test URLs:
https://rparrish-editorial-card--milo--adobecom.hlx.page/drafts/rparrish/cards/editorial-cards
Design Requirements
https://www.figma.com/design/WSOUE5ISObLLA0Tff5LwM7/Brief%3A-Manual-Cards-5%2F24?node-id=2003-9165
Document
https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7BD2753A55-82B2-4174-A941-A98D19C07BF2%7D&file=Editorial%20Cards.docx&action=default&mobileredirect=true
Related Task: MWPW-150566 ! Not a dependency !
Grid enhancements